TargetEditor.TargetChangedListener appears to expect to run on the UI

wimjongman · laeubi · commit 6c61abc97f0a · 2025-01-01T08:32:14.000+01:00
thread #1505 Possible fix for #1505
diff --git a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/targetdefinition/TargetEditor.java b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/targetdefinition/TargetEditor.java
@@ -532,7 +532,8 @@ private ITargetDefinition loadTargetDefinition() throws CoreException {
 				fTarget = service.newTarget();
 				throw e;
 			}
-			TargetEditor.this.getTargetChangedListener().contentsChanged(fTarget, this, true, false);
+			PlatformUI.getWorkbench().getDisplay().asyncExec(
+					() -> TargetEditor.this.getTargetChangedListener().contentsChanged(fTarget, this, true, false));
 			return fTarget;
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -532,7 +532,8 @@ private ITargetDefinition loadTargetDefinition() throws CoreException {`
`532`	`532`	`fTarget = service.newTarget();`
`533`	`533`	`throw e;`
`534`	`534`	`}`
`535`		`- TargetEditor.this.getTargetChangedListener().contentsChanged(fTarget, this, true, false);`
	`535`	`+ PlatformUI.getWorkbench().getDisplay().asyncExec(`
	`536`	`+ () -> TargetEditor.this.getTargetChangedListener().contentsChanged(fTarget, this, true, false));`
`536`	`537`	`return fTarget;`
`537`	`538`	`}`
`538`	`539`