Prevents NPE when using the result of TargetDefinition.getBundles()

Extract the logic to a new private method and add null-check.

Author: fedejeanne

ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/shared/target/TargetContentsGroup.java

@@ -1166,14 +1166,7 @@ public Object[] getElements(Object inputElement) {
 				if (fMissing == null || fMissing.isEmpty()) {
 					fMissing = new HashSet<>(); // A set is used to remove copies of problem bundles
 					TargetBundle[] bundles = fTargetDefinition.getBundles();
-					for (int i = 0; i < bundles.length; i++) {
-						if (!bundles[i].getStatus().isOK()) {
-							// We only display error bundles that have symbolic names
-							if (bundles[i].getBundleInfo().getSymbolicName() != null) {
-								fMissing.add(bundles[i]);
-							}
-						}
-					}
+					addMissing(bundles);
 					result.addAll(fMissing);
 				} else {
 					// As missing bundles are unchecked, we want to keep them in the table, only if locations change does fMissing become null
@@ -1208,6 +1201,20 @@ public Object[] getElements(Object inputElement) {
 			return new Object[] {inputElement};
 		}
 
+		private void addMissing(TargetBundle[] bundles) {
+			if (bundles == null)
+				return;
+
+			for (TargetBundle bundle : bundles) {
+				if (!bundle.getStatus().isOK()) {
+					// We only display error bundles that have symbolic names
+					if (bundle.getBundleInfo().getSymbolicName() != null) {
+						fMissing.add(bundle);
+					}
+				}
+			}
+		}
+
 	}
 
 }