Skip to content

Commit 9851080

Browse files
Dani-HubHannesWell
authored andcommitted
Support SVG icons in extension point editor
Fixes #2025 For modernization also replace array field by List field Signed-off-by: Daniel Krügler <[email protected]>
1 parent 3201782 commit 9851080

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/plugin/ExtensionsSection.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
* Brian de Alwis (MTI) - bug 429420
1717
* Lars Vogel <[email protected]> - Bug 487943
1818
* Martin Karpisek <[email protected]> - Bug 351356
19+
* Daniel Kruegler - #2025 - SVG icons not supported by extension point editor
1920
*******************************************************************************/
2021
package org.eclipse.pde.internal.ui.editor.plugin;
2122

@@ -151,7 +152,7 @@ public class ExtensionsSection extends TreeSection implements IPropertyChangeLis
151152
"commandId", "property", "activityId", //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
152153
"attribute", "value"}; //$NON-NLS-1$ //$NON-NLS-2$
153154

154-
private static final String[] VALID_IMAGE_TYPES = {"png", "bmp", "ico", "gif", "jpg", "tiff"}; //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ //$NON-NLS-4$ //$NON-NLS-5$ //$NON-NLS-6$
155+
private static final List<String> VALID_IMAGE_TYPES = List.of("png", "bmp", "ico", "gif", "jpg", "tiff", "svg"); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ //$NON-NLS-4$ //$NON-NLS-5$ //$NON-NLS-6$ //$NON-NLS-7$
155156
private static final String MENU_NEW_ID = "NewMenu"; //$NON-NLS-1$
156157

157158
class ExtensionContentProvider implements ITreeContentProvider {

0 commit comments

Comments
 (0)