Check for mixed JUnit 5 and JUnit 6 launch type and required bundles

This changes ensures an error dialog is shown,
if a user runs a JUnit 5 launch with required JUnit 6 bundles.

Fixes: #2045

Author: trancexpress

ui/org.eclipse.pde.launching/src/org/eclipse/pde/internal/launching/JUnitLaunchRequirements.java

@@ -14,7 +14,9 @@
 package org.eclipse.pde.internal.launching;
 
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.Collection;
+import java.util.HashSet;
 import java.util.LinkedHashSet;
 import java.util.List;
 import java.util.Map;
@@ -41,7 +43,16 @@ public class JUnitLaunchRequirements {
 	private static final String JUNIT4_JDT_RUNTIME_PLUGIN = "org.eclipse.jdt.junit4.runtime"; //$NON-NLS-1$
 	private static final String JUNIT5_JDT_RUNTIME_PLUGIN = "org.eclipse.jdt.junit5.runtime"; //$NON-NLS-1$
 
+	private static final Set<String> JUNIT_JUPITER_BUNLDES = new HashSet<>(Arrays.asList(new String[] {
+			"junit-jupiter-api", //$NON-NLS-1$
+			"org.junit.jupiter.api", //$NON-NLS-1$
+			"junit-jupiter-engine", //$NON-NLS-1$
+			"org.junit.jupiter.engine", //$NON-NLS-1$
+	}));
+
+
 	public static void addRequiredJunitRuntimePlugins(ILaunchConfiguration configuration, Map<String, List<IPluginModelBase>> collectedModels, Map<IPluginModelBase, String> startLevelMap) throws CoreException {
+		checkJunitVersion(configuration, startLevelMap.keySet());
 		Collection<String> runtimePlugins = getRequiredJunitRuntimeEclipsePlugins(configuration);
 		Set<BundleDescription> addedRuntimeBundles = addAbsentRequirements(runtimePlugins, collectedModels, startLevelMap);
 		Set<BundleDescription> runtimeRequirements = DependencyManager.findRequirementsClosure(addedRuntimeBundles);
@@ -103,4 +114,31 @@ private static IPluginModelBase findRequiredPluginInTargetOrHost(IPluginModelBas
 		return model;
 	}
 
+	@SuppressWarnings("restriction")
+	private static void checkJunitVersion(ILaunchConfiguration configuration, Set<IPluginModelBase> models) throws CoreException {
+		org.eclipse.jdt.internal.junit.launcher.ITestKind testKind = org.eclipse.jdt.internal.junit.launcher.JUnitLaunchConfigurationConstants.getTestRunnerKind(configuration);
+		if (testKind.isNull()) {
+			return;
+		}
+		switch (testKind.getId()) {
+			case org.eclipse.jdt.internal.junit.launcher.TestKindRegistry.JUNIT5_TEST_KIND_ID -> checkJunit5Version(models);
+		}
+	}
+
+	private static void checkJunit5Version(Set<IPluginModelBase> models) throws CoreException {
+		List<String> junit6Bundles = junitBundles(models, 6);
+		if (!junit6Bundles.isEmpty()) {
+			String bundleIds = String.join(", ", junit6Bundles); //$NON-NLS-1$
+			throw new CoreException(Status.error(NLS.bind(PDEMessages.JUnitLaunchConfiguration_error_JUnit5LaunchJUnit6Runtime, bundleIds)));
+		}
+	}
+
+	private static List<String> junitBundles(Set<IPluginModelBase> models, int majorVersion) {
+		List<String> junit6Bundles = models.stream()
+				.map(IPluginModelBase::getBundleDescription)
+				.filter(d -> JUNIT_JUPITER_BUNLDES.contains(d.getSymbolicName()) && d.getVersion().getMajor() == 6)
+				.map(BundleDescription::getSymbolicName)
+				.toList();
+		return junit6Bundles;
+	}
 }

ui/org.eclipse.pde.launching/src/org/eclipse/pde/internal/launching/PDEMessages.java

@@ -36,6 +36,7 @@ public class PDEMessages extends NLS {
 	public static String WorkbenchLauncherConfigurationDelegate_noStartup;
 	public static String JUnitLaunchConfiguration_error_notaplugin;
 	public static String JUnitLaunchConfiguration_error_missingPlugin;
+	public static String JUnitLaunchConfiguration_error_JUnit5LaunchJUnit6Runtime;
 
 	public static String OSGiLaunchConfiguration_cannotFindLaunchConfiguration;
 	public static String OSGiLaunchConfiguration_selected;

ui/org.eclipse.pde.launching/src/org/eclipse/pde/internal/launching/pderesources.properties

@@ -25,6 +25,7 @@ WorkbenchLauncherConfigurationDelegate_jrePathNotFound = The installation path t
 WorkbenchLauncherConfigurationDelegate_noStartup = Launching failed. Bootstrap code cannot be found.
 JUnitLaunchConfiguration_error_notaplugin = Could not launch the JUnit plug-in tests because project ''{0}'' is not a plug-in project.
 JUnitLaunchConfiguration_error_missingPlugin = Required plug-in ''{0}'' could not be found.
+JUnitLaunchConfiguration_error_JUnit5LaunchJUnit6Runtime = JUnit 5 type launch cannot run with JUnit 6 bundles. Update the launch to use JUnit 6 or restrict version requirements of ''{0}'' to JUnit 5.
 
 OSGiLaunchConfiguration_cannotFindLaunchConfiguration=Cannot find the {0} OSGi framework.
 OSGiLaunchConfiguration_selected=selected