Skip to content

Commit d8e6716

Browse files
committed
CSS Spy: fix NPE in WidgetTreeProvider #1381
for items that can not be styled with CSS #1381
1 parent 6506ee6 commit d8e6716

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

features/org.eclipse.pde.spies-feature/feature.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<feature
33
id="org.eclipse.pde.spies"
44
label="%featureName"
5-
version="1.0.400.qualifier"
5+
version="1.0.500.qualifier"
66
provider-name="%providerName"
77
license-feature="org.eclipse.license"
88
license-feature-version="0.0.0">

ui/org.eclipse.pde.spy.css/META-INF/MANIFEST.MF

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
22
Bundle-ManifestVersion: 2
33
Bundle-Name: %name
44
Bundle-SymbolicName: org.eclipse.pde.spy.css;singleton:=true
5-
Bundle-Version: 0.13.400.qualifier
5+
Bundle-Version: 0.13.500.qualifier
66
Automatic-Module-Name: org.eclipse.pde.spy.css
77
Bundle-RequiredExecutionEnvironment: JavaSE-17
88
Require-Bundle: org.eclipse.core.runtime;bundle-version="3.29.0",

ui/org.eclipse.pde.spy.css/src/org/eclipse/pde/spy/css/WidgetTreeProvider.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,9 @@ public Object[] getChildren(Object parentElement) {
5858
NodeList kids = element.getChildNodes();
5959
ArrayList<Object> children = new ArrayList<>(kids.getLength());
6060
for (int i = 0; i < kids.getLength(); i++) {
61-
children.add(((CSSStylableElement) kids.item(i)).getNativeWidget());
61+
if (kids.item(i) instanceof CSSStylableElement kid) {
62+
children.add(kid.getNativeWidget());
63+
}
6264
}
6365
return children.toArray();
6466
}

0 commit comments

Comments
 (0)