Skip to content

Commit f98c69c

Browse files
eclipse-pde-botakurtakov
authored andcommitted
Perform clean code of ui/org.eclipse.pde.core
1 parent 2b81907 commit f98c69c

File tree

3 files changed

+33
-0
lines changed

3 files changed

+33
-0
lines changed

ui/org.eclipse.pde.core/src/org/eclipse/pde/core/plugin/PluginRegistry.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ public static class PluginFilter {
7373
* @param model plug-in model
7474
* @return whether accepted by this filter
7575
*/
76+
@Deprecated
7677
public boolean accept(IPluginModelBase model) {
7778
return true;
7879
}

ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/update/configurator/PlatformConfiguration.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ public class PlatformConfiguration implements IConfigurationConstants {
4747

4848
private static URL installURL;
4949

50+
@Deprecated
5051
public PlatformConfiguration(URL url) throws Exception {
5152
URL installLocation = Utils.getInstallURL();
5253
// Retrieve install location with respect to given url if possible
@@ -61,10 +62,12 @@ public PlatformConfiguration(URL url) throws Exception {
6162
initialize(url, installLocation);
6263
}
6364

65+
@Deprecated
6466
public static int getDefaultPolicy() {
6567
return defaultPolicy;
6668
}
6769

70+
@Deprecated
6871
public SiteEntry[] getConfiguredSites() {
6972
if (config == null) {
7073
return new SiteEntry[0];
@@ -146,6 +149,7 @@ private Configuration loadConfig(URL url, URL installLocation) throws Exception
146149
return config;
147150
}
148151

152+
@Deprecated
149153
public static boolean supportsDetection(URL url, URL installLocation) {
150154
String protocol = url.getProtocol();
151155
if (protocol.equals("file")) { //$NON-NLS-1$
@@ -163,6 +167,7 @@ public static boolean supportsDetection(URL url, URL installLocation) {
163167
}
164168
}
165169

170+
@Deprecated
166171
public static URL resolvePlatformURL(URL url, URL base_path_Location) throws IOException {
167172
if (url.getProtocol().equals("platform")) { //$NON-NLS-1$
168173
if (base_path_Location == null) {
@@ -185,10 +190,12 @@ public static URL resolvePlatformURL(URL url, URL base_path_Location) throws IOE
185190
return url;
186191
}
187192

193+
@Deprecated
188194
public static URL getInstallURL() {
189195
return installURL;
190196
}
191197

198+
@Deprecated
192199
public Configuration getConfiguration() {
193200
return config;
194201
}

ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/update/configurator/SiteEntry.java

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,12 @@ public class SiteEntry implements IConfigurationConstants {
4646
private static FeatureParser featureParser = new FeatureParser();
4747
private static boolean isMacOS = Utils.getOS().equals(Constants.OS_MACOSX);
4848

49+
@Deprecated
4950
public SiteEntry(URL url) {
5051
this(url, null);
5152
}
5253

54+
@Deprecated
5355
public SiteEntry(URL url, SitePolicy policy) {
5456
if (url == null) {
5557
try {
@@ -82,6 +84,7 @@ public SiteEntry(URL url, SitePolicy policy) {
8284
this.resolvedURL = this.url;
8385
}
8486

87+
@Deprecated
8588
public void setConfig(Configuration config) {
8689
this.config = config;
8790
if (url.getProtocol().equals("platform")) { //$NON-NLS-1$
@@ -101,62 +104,74 @@ public void setConfig(Configuration config) {
101104
}
102105
}
103106

107+
@Deprecated
104108
public Configuration getConfig() {
105109
return config;
106110
}
107111

112+
@Deprecated
108113
public URL getURL() {
109114
return url;
110115
}
111116

117+
@Deprecated
112118
public SitePolicy getSitePolicy() {
113119
return policy;
114120
}
115121

122+
@Deprecated
116123
public synchronized void setSitePolicy(SitePolicy policy) {
117124
if (policy == null) {
118125
throw new IllegalArgumentException();
119126
}
120127
this.policy = policy;
121128
}
122129

130+
@Deprecated
123131
public String[] getFeatures() {
124132
return getDetectedFeatures();
125133
}
126134

135+
@Deprecated
127136
public long getChangeStamp() {
128137
if (changeStamp == 0) {
129138
computeChangeStamp();
130139
}
131140
return changeStamp;
132141
}
133142

143+
@Deprecated
134144
public long getFeaturesChangeStamp() {
135145
if (featuresChangeStamp == 0) {
136146
computeFeaturesChangeStamp();
137147
}
138148
return featuresChangeStamp;
139149
}
140150

151+
@Deprecated
141152
public long getPluginsChangeStamp() {
142153
if (pluginsChangeStamp == 0) {
143154
computePluginsChangeStamp();
144155
}
145156
return pluginsChangeStamp;
146157
}
147158

159+
@Deprecated
148160
public boolean isUpdateable() {
149161
return updateable;
150162
}
151163

164+
@Deprecated
152165
public void setUpdateable(boolean updateable) {
153166
this.updateable = updateable;
154167
}
155168

169+
@Deprecated
156170
public boolean isNativelyLinked() {
157171
return isExternallyLinkedSite();
158172
}
159173

174+
@Deprecated
160175
public URL getResolvedURL() {
161176
return resolvedURL;
162177
}
@@ -306,18 +321,22 @@ private long computeStamp(String[] targets) {
306321
return result;
307322
}
308323

324+
@Deprecated
309325
public void setLinkFileName(String linkFileName) {
310326
this.linkFileName = linkFileName;
311327
}
312328

329+
@Deprecated
313330
public String getLinkFileName() {
314331
return linkFileName;
315332
}
316333

334+
@Deprecated
317335
public boolean isExternallyLinkedSite() {
318336
return (linkFileName != null && !linkFileName.trim().isEmpty());
319337
}
320338

339+
@Deprecated
321340
public void addFeatureEntry(FeatureEntry feature) {
322341
if (featureEntries == null) {
323342
featureEntries = new HashMap<>();
@@ -346,6 +365,7 @@ public void addFeatureEntry(FeatureEntry feature) {
346365
feature.setSite(this);
347366
}
348367

368+
@Deprecated
349369
public FeatureEntry[] getFeatureEntries() {
350370
if (featureEntries == null) {
351371
detectFeatures();
@@ -375,14 +395,17 @@ private void validateFeatureEntries() {
375395
}
376396
}
377397

398+
@Deprecated
378399
public boolean isEnabled() {
379400
return enabled;
380401
}
381402

403+
@Deprecated
382404
public void setEnabled(boolean enable) {
383405
this.enabled = enable;
384406
}
385407

408+
@Deprecated
386409
public FeatureEntry getFeatureEntry(String id) {
387410
for (FeatureEntry feature : getFeatureEntries()) {
388411
if (feature.getFeatureIdentifier().equals(id)) {
@@ -392,6 +415,7 @@ public FeatureEntry getFeatureEntry(String id) {
392415
return null;
393416
}
394417

418+
@Deprecated
395419
public boolean unconfigureFeatureEntry(FeatureEntry feature) {
396420
FeatureEntry existingFeature = getFeatureEntry(feature.getFeatureIdentifier());
397421
if (existingFeature != null) {
@@ -405,6 +429,7 @@ public boolean unconfigureFeatureEntry(FeatureEntry feature) {
405429
* site is initialized from platform.xml we need to set the feature set to
406430
* empty, so we don't try to detect them.
407431
*/
432+
@Deprecated
408433
public void initialized() {
409434
if (featureEntries == null) {
410435
featureEntries = new HashMap<>();

0 commit comments

Comments
 (0)