Ambiguous button names in dependency properties dialog

[ptziegler]

Whenever I need to update the version range of a plugin/import, I find myself having to do the same change twice, because I accidentally clicked on "Cancel", rather than "Close".

I find it very confusing to use words with a very similar meaning right next to each other and I think it makes sense to rename "Close" to e,g, "Apply".

[ptziegler]

This should be where the name is defined:

eclipse.pde/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/pderesources.properties

Lines 1456 to 1458 in 515f996

	DependencyPropertiesDialog_exportGroupText=Version exported
	DependencyPropertiesDialog_closeButtonLabel=&Close
	DependencyAnalysisSection_plugin_notEditable = <form>\

[vogella]

+1 for this proposal. PR welcome

[merks]

I agree that's weird. One would expect OK to be the default or something more explicit like Apply being a good idea.