Rename "Close" to "Apply" in DependencyPropertiesDialog

[ptziegler]

This changes the name of the OK button to "Close", to avoid any confusion with the similarly named "Cancel" button.

Closes #1632

[ptziegler]

I think the buttons are sorted lexicographically, so the OK button is now the first button. This might mess with muscle memory, but I'm not sure if it's worth changing, especially because you have the same in e.g. the property pages.

[github-actions]

Test Results

   285 files  +   285     285 suites  +285   47m 9s ⏱️ + 47m 9s
 3 608 tests + 3 608   3 532 ✅ + 3 532   76 💤 + 76  0 ❌ ±0 
11 016 runs  +11 016  10 785 ✅ +10 785  231 💤 +231  0 ❌ ±0 

Results for commit 0da2139. ± Comparison against base commit 515f996.

[merks]

The button order is different (opposite) on MacOs than on Windows/Linux. Buttons are not sorted...

https://stackoverflow.com/questions/6667271/standard-placement-order-for-common-buttons

[vogella]

I think the buttons are sorted lexicographically, so the OK button is now the first button. This might mess with muscle memory, but I'm not sure if it's worth changing, especially because you have the same in e.g. the property pages.

Did you test / develop on different platforms? As @merks said, button are OS specific

[ptziegler]

Did you test / develop on different platforms? As @merks said, button are OS specific

The order is definitely OS specific. On Windows, the order is "Apply" "Cancel" but on Linux it's "Cancel" "Apply". Weird... 🤷

[vogella]

Test / build failure seems unrelated.

Thanks @ptziegler

[akurtakov]

Please don't merge things until we open the stream. I don't want such merges to break build due to missing version bumps or etc.