org.eclipse.pde.ds.annotations.tests project shows compilation errors in I20251029-1800

[iloveeclipse]

I've just noticed that today with I20251029-1800 build because I had org.eclipse.pde.ds.annotations.tests project closed before.
Seem to be side effect of b235a27 (plus recent changes?).

The org.eclipse.pde.ds.annotations.tests/META-INF/MANIFEST.MF file doesn't specify anywhere that it needs JUnit 4 libraries, yet org.junit_4.13.2.v20240929-1000.jar is added to the classpath in the IDE (I assume PDE does that under the hood, which seem to be wrong, but anyway). I also have no clue how it compiles at all on command line if code says

import org.junit.After;
import org.junit.Before;

but no one imports org.junit bundle nor package.

In the code the JUnit 4 API is really used next to JUnit 5, probably that causes strange compilation issues.
Instead of org.junit.Before org.junit.jupiter.api.BeforeEach should be used and so on.

[iloveeclipse]

@stephan-herrmann : I wonder if you could check the errors here and whether is that another side effect of eclipse-jdt/eclipse.jdt.core#4293 ? I honestly don't understand what compiler tries to say to me about restrictions and how one can "fix" that.

[stephan-herrmann]

@stephan-herrmann : I wonder if you could check the errors here and whether is that another side effect of eclipse-jdt/eclipse.jdt.core#4293 ? I honestly don't understand what compiler tries to say to me about restrictions and how one can "fix" that.

I have to leave just now. Regarding restriction problems perhaps @laeubi can help?

[laeubi]

I need to look into the details BUT:

• PDE + Tycho use a little bit different regarding classpath resolution where Tycho is more complete
• So it can happen that build is happy but IDE complains
• In this case if you do not import the package directly it might be provided indirectly by one of the required bundles and PDE does not correctly honor this
• It would not hurt to import the assertion package

[iloveeclipse]

Anyway, I've simply moved remaining tests to IUnit 5 now: #2170
With that compilation errors are gone.