From 0da213988fd9bbf223c552462220fc74b6400b8b Mon Sep 17 00:00:00 2001 From: Patrick Ziegler Date: Mon, 3 Mar 2025 19:46:20 +0100 Subject: [PATCH] Rename "Close" to "Apply" in DependencyPropertiesDialog This changes the name of the OK button to "Close", to avoid any confusion with the similarly named "Cancel" button. Closes https://github.com/eclipse-pde/eclipse.pde/issues/1632 --- .../src/org/eclipse/pde/internal/ui/PDEUIMessages.java | 4 ++-- .../internal/ui/editor/plugin/DependencyPropertiesDialog.java | 4 ++-- .../src/org/eclipse/pde/internal/ui/pderesources.properties | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/PDEUIMessages.java b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/PDEUIMessages.java index 3eea5272e9b..c08c0d83449 100644 --- a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/PDEUIMessages.java +++ b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/PDEUIMessages.java @@ -1,5 +1,5 @@ /******************************************************************************* - * Copyright (c) 2014, 2024 IBM Corporation and others. + * Copyright (c) 2014, 2025 IBM Corporation and others. * * This program and the accompanying materials * are made available under the terms of the Eclipse Public License 2.0 @@ -77,7 +77,7 @@ public class PDEUIMessages extends NLS { public static String DependenciesViewPage_showOptional; public static String DependencyPropertiesDialog_exportGroupText; - public static String DependencyPropertiesDialog_closeButtonLabel; + public static String DependencyPropertiesDialog_applyButtonLabel; public static String ExtensionsPage_toggleExpandState; public static String ExternalizeStringsOperation_editNames_addComment; diff --git a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/plugin/DependencyPropertiesDialog.java b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/plugin/DependencyPropertiesDialog.java index 88ef21f729f..ee5e6457481 100644 --- a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/plugin/DependencyPropertiesDialog.java +++ b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/plugin/DependencyPropertiesDialog.java @@ -1,5 +1,5 @@ /******************************************************************************* - * Copyright (c) 2005, 2015 IBM Corporation and others. + * Copyright (c) 2005, 2025 IBM Corporation and others. * * This program and the accompanying materials * are made available under the terms of the Eclipse Public License 2.0 @@ -83,7 +83,7 @@ protected String getGroupText() { @Override protected void createButtonsForButtonBar(Composite parent) { - createButton(parent, IDialogConstants.OK_ID, PDEUIMessages.DependencyPropertiesDialog_closeButtonLabel, true); + createButton(parent, IDialogConstants.OK_ID, PDEUIMessages.DependencyPropertiesDialog_applyButtonLabel, true); createButton(parent, IDialogConstants.CANCEL_ID, IDialogConstants.CANCEL_LABEL, false); } diff --git a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/pderesources.properties b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/pderesources.properties index b1ef2e0fa9e..09e207aec3c 100644 --- a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/pderesources.properties +++ b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/pderesources.properties @@ -1,5 +1,5 @@ ############################################################################### -# Copyright (c) 2000, 2024 IBM Corporation and others. +# Copyright (c) 2000, 2025 IBM Corporation and others. # # This program and the accompanying materials # are made available under the terms of the Eclipse Public License 2.0 @@ -1454,7 +1454,7 @@ DependencyPropertiesDialog_comboExclusive=Exclusive DependencyPropertiesDialog_minimumVersion=&Minimum version: DependencyPropertiesDialog_maximumVersion=Ma&ximum version: DependencyPropertiesDialog_exportGroupText=Version exported -DependencyPropertiesDialog_closeButtonLabel=&Close +DependencyPropertiesDialog_applyButtonLabel=&Apply DependencyAnalysisSection_plugin_notEditable =
\

Show the plug-in dependency hierarchy

\

Show dependent plug-ins and fragments

\