Skip to content

Fix and run pde.ds.annotation.tests and replace leftover JUnit-4 Assume #2085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix and run pde.ds.annotation.tests and replace leftover JUnit-4 Assume #2085

wants to merge 2 commits into from

Conversation

@HannesWell
Copy link
Member

@HannesWell HannesWell commented Nov 1, 2025 •
edited
Loading

Convert assumptions to assertions since all of them should actually be assertions.
Furthermore this replaces leftover JUnit-4 assumptions.

This is currently a draft as not everything is working yet locally.

Follow-up on

HannesWell and others added 2 commits November 1, 2025 16:16
@HannesWell
Fix and run pde.ds.annotation.tests and replace leftover JUnit-4 Assume
1f4cde1 
Convert assumptions to assertions since all of them should actually be
assertions.
Furthermore this replaces leftover JUnit-4 assumptions.
@eclipse-pde-bot
Version bump(s) for 4.38 stream
f2ea1c6
@eclipse-pde-bot
Copy link
Contributor

eclipse-pde-bot commented Nov 1, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ds/org.eclipse.pde.ds.annotations/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch 
From 7092b5d533d531381c8d30ae873a4c3fdd120548 Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <[email protected]>
Date: Sat, 1 Nov 2025 15:29:04 +0000
Subject: [PATCH] Version bump(s) for 4.38 stream


diff --git a/ds/org.eclipse.pde.ds.annotations/META-INF/MANIFEST.MF b/ds/org.eclipse.pde.ds.annotations/META-INF/MANIFEST.MF
index 51e4220f81..7da71696df 100644
--- a/ds/org.eclipse.pde.ds.annotations/META-INF/MANIFEST.MF
+++ b/ds/org.eclipse.pde.ds.annotations/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Bundle-Name
 Bundle-SymbolicName: org.eclipse.pde.ds.annotations;singleton:=true
-Bundle-Version: 1.4.200.qualifier
+Bundle-Version: 1.4.300.qualifier
 Bundle-Activator: org.eclipse.pde.ds.internal.annotations.Activator
 Bundle-Vendor: %Bundle-Vendor
 Require-Bundle: org.eclipse.ui;bundle-version="[3.105.0,4.0.0)",
-- 
2.51.2

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link

github-actions bot commented Nov 1, 2025

Test Results

  650 files   -   121    650 suites   - 121   59m 46s ⏱️ +40s
3 772 tests +  139  3 586 ✅ +    8   54 💤 ± 0  132 ❌ +131 
8 432 runs   - 2 401  8 179 ✅  - 2 490  139 💤  - 24  114 ❌ +113 

For more details on these failures, see this check.

Results for commit f2ea1c6. ± Comparison against base commit 9f7c60d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HannesWell @eclipse-pde-bot