Skip to content

Conversation

@HannesWell
Copy link
Member

mainly on Windows.

Follow-up on

On Windows 11 this now looks like

Before it was

Alternatively we could set the Text field enabled=false instead of editable=false/READ_ONLY:

or could just use a plain label (Label message = new Label(container, SWT.BORDER | SWT.WRAP);, with modified text to be longer):

@trancexpress can you compare it for Linux and tell what works best?

@HannesWell HannesWell force-pushed the multiline-validation-errors branch from c38a43d to 9f90486 Compare November 2, 2025 11:47
@HannesWell
Copy link
Member Author

Just pushed another refinement. On Win11 it now looks like:

Except for the cursor in the error message, this looks good to me. at least for my case.

@trancexpress
Copy link
Contributor

@HannesWell on Linux the dialog looks like this:

Screenshot_20251102_142720

There is also a horizontal scrollbar when the message is just one long line, so IMO it looks fine.

@HannesWell
Copy link
Member Author

There is also a horizontal scrollbar when the message is just one long line, so IMO it looks fine.

Thanks for checking.
Lets give others a day to comment and if there are no objections I'll submit it.

@github-actions
Copy link

github-actions bot commented Nov 2, 2025

Test Results

   771 files  ±0     771 suites  ±0   1h 6m 49s ⏱️ + 6m 42s
 3 633 tests ±0   3 578 ✅  - 1   54 💤 ±0  1 ❌ +1 
10 833 runs  ±0  10 669 ✅  - 1  163 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit bc1bcb6. ± Comparison against base commit 2b81907.

♻️ This comment has been updated with latest results.

@HannesWell HannesWell force-pushed the multiline-validation-errors branch from 9f90486 to bc1bcb6 Compare November 3, 2025 17:33
@HannesWell
Copy link
Member Author

Because the JUnit launch validation was removed via #2092, this is now obsolete as well.

@HannesWell HannesWell closed this Nov 5, 2025
@HannesWell HannesWell deleted the multiline-validation-errors branch November 5, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants