From eb1d82b12629e1c2ed97d81b350128a82a11b290 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=90=D0=BB=D0=B5=D0=BA=D1=81=D0=B0=D0=BD=D0=B4=D1=8A?= =?UTF-8?q?=D1=80=20=D0=9A=D1=83=D1=80=D1=82=D0=B0=D0=BA=D0=BE=D0=B2?= Date: Tue, 4 Nov 2025 19:04:39 +0200 Subject: [PATCH] Fix ImageBrowserView combos popup transparency On Fedora 43 system SWT.COLOR_LIST_BACKGROUND comes with transparency set and this misrenders combos popup as the color is inherited by children. Not setting any color at all is the simplest and most naturally fitting choice to fix the problem. --- .../ui/views/imagebrowser/ImageBrowserView.java | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/views/imagebrowser/ImageBrowserView.java b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/views/imagebrowser/ImageBrowserView.java index 2eb674db1f..10eb79e45a 100644 --- a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/views/imagebrowser/ImageBrowserView.java +++ b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/views/imagebrowser/ImageBrowserView.java @@ -1,5 +1,5 @@ /******************************************************************************* - * Copyright (c) 2012, 2018 Christian Pontesegger and others. + * Copyright (c) 2012, 2025 Christian Pontesegger and others. * * This program and the accompanying materials * are made available under the terms of the Eclipse Public License 2.0 @@ -167,7 +167,6 @@ public ImageBrowserView() { public void createPartControl(final Composite parent) { final Composite composite = SWTFactory.createComposite(parent, 1, 1, GridData.FILL_BOTH, 0, 0); PlatformUI.getWorkbench().getHelpSystem().setHelp(composite, IHelpContextIds.IMAGE_BROWSER_VIEW); - composite.setBackground(parent.getDisplay().getSystemColor(SWT.COLOR_LIST_BACKGROUND)); Composite topComp = new Composite(composite, SWT.NONE); RowLayout layout = new RowLayout(); // need to center vertically, otherwise its looks misaligned @@ -231,12 +230,9 @@ public void createPartControl(final Composite parent) { spinMaxImages.setSelection(250); spinMaxImages.setLayoutData(GridDataFactory.fillDefaults().create()); spinMaxImages.addModifyListener(e -> { - Display.getCurrent().asyncExec(new Runnable() { - @Override - public void run() { - page = 0; // reset to 1st page - scanImages(); - } + Display.getCurrent().asyncExec(() -> { + page = 0; // reset to 1st page + scanImages(); }); });