Skip to content

Commit 11833b7

Browse files
committed
[PHP84] Correct facet versions
1 parent 3af9325 commit 11833b7

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

plugins/org.eclipse.php.core/src/org/eclipse/php/internal/core/facet/PHPFacets.java

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,12 @@ public static PHPVersion getPHPVersionFromFacets(IProject project) {
135135
if (PHPFacetsConstants.PHP_COMPONENT_VERSION_8_3.equals(version.getVersionString())) {
136136
return PHPVersion.PHP8_3;
137137
}
138+
if (PHPFacetsConstants.PHP_COMPONENT_VERSION_8_4.equals(version.getVersionString())) {
139+
return PHPVersion.PHP8_4;
140+
}
141+
if (PHPFacetsConstants.PHP_COMPONENT_VERSION_8_5.equals(version.getVersionString())) {
142+
return PHPVersion.PHP8_5;
143+
}
138144
}
139145
} catch (CoreException ex) {
140146
// silently ignore
@@ -180,8 +186,12 @@ public static IProjectFacetVersion convertToFacetVersion(PHPVersion version) {
180186
case PHP8_2:
181187
return phpFacet.getVersion(PHPFacetsConstants.PHP_COMPONENT_VERSION_8_2);
182188
case PHP8_3:
183-
default:
184189
return phpFacet.getVersion(PHPFacetsConstants.PHP_COMPONENT_VERSION_8_3);
190+
case PHP8_4:
191+
return phpFacet.getVersion(PHPFacetsConstants.PHP_COMPONENT_VERSION_8_4);
192+
case PHP8_5:
193+
default:
194+
return phpFacet.getVersion(PHPFacetsConstants.PHP_COMPONENT_VERSION_8_5);
185195
}
186196
}
187197

plugins/org.eclipse.php.core/src/org/eclipse/php/internal/core/facet/PHPFacetsConstants.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,4 +32,6 @@ public class PHPFacetsConstants {
3232
public static final String PHP_COMPONENT_VERSION_8_1 = "8.1"; //$NON-NLS-1$
3333
public static final String PHP_COMPONENT_VERSION_8_2 = "8.2"; //$NON-NLS-1$
3434
public static final String PHP_COMPONENT_VERSION_8_3 = "8.3"; //$NON-NLS-1$
35+
public static final String PHP_COMPONENT_VERSION_8_4 = "8.4"; //$NON-NLS-1$
36+
public static final String PHP_COMPONENT_VERSION_8_5 = "8.5"; //$NON-NLS-1$
3537
}

0 commit comments

Comments
 (0)