Skip to content

Commit 5bddc6c

Browse files
laeubiakurtakov
authored andcommitted
Define a single property for the releaseVersion and use in property
Actually the both properties 'releaseNumberSDK' and 'releaseNumberPlatform' are always the same and even if the comment mentions they might be different at some time it is better to unify them until then. Because of this there is now a new 'releaseVersion' defined as a single property.
1 parent 56ba8ab commit 5bddc6c

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

.github/workflows/prepareRelease.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ jobs:
3434
- name: Update Main Versions
3535
run: mvn -U -ntp -f eclipse-platform-parent org.eclipse.tycho:tycho-versions-plugin:set-version -DnewVersion=${{ github.event.milestone.title }}.0-SNAPSHOT -Dmodules=../eclipse.platform.releng.prereqs.sdk
3636
- name: Update Release Versions
37-
run: mvn -ntp -f eclipse-platform-parent/pom.xml --non-recursive org.eclipse.tycho:tycho-versions-plugin:set-property -Dproperties=releaseNumberSDK,releaseNumberPlatform,releaseName -DnewReleaseName=${{ steps.get-release-name.outputs.name }} -DnewReleaseNumberSDK=${{ github.event.milestone.title }} -DnewReleaseNumberPlatform=${{ github.event.milestone.title }}
37+
run: mvn -ntp -f eclipse-platform-parent/pom.xml --non-recursive org.eclipse.tycho:tycho-versions-plugin:set-property -Dproperties=releaseVersion,releaseName -DnewReleaseName=${{ steps.get-release-name.outputs.name }} -DnewreleaseVersion=${{ github.event.milestone.title }}
3838
- name: Create Pull Request for Release ${{ github.event.milestone.title }}
3939
uses: peter-evans/create-pull-request@5e914681df9dc83aa4e4905692ca88beb2f9e91f # v7.0.5
4040
with:

eclipse-platform-parent/pom.xml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@
5050
See bug 328139.
5151
-->
5252
<releaseName>2025-03</releaseName>
53+
<releaseVersion>4.35</releaseVersion>
5354
<!--
5455
The releaseNumbers below, for SDK and Platform, might be
5556
thought of as the "marketing number" or "branding number",
@@ -64,8 +65,8 @@
6465
but we'd still want the "marketing number" to be increased to reflect
6566
"a new yearly release".
6667
-->
67-
<releaseNumberSDK>4.35</releaseNumberSDK>
68-
<releaseNumberPlatform>4.35</releaseNumberPlatform>
68+
<releaseNumberSDK>${releaseVersion}</releaseNumberSDK>
69+
<releaseNumberPlatform>${releaseVersion}</releaseNumberPlatform>
6970

7071
<tycho.version>4.0.10</tycho.version>
7172

0 commit comments

Comments
 (0)