Skip to content

Commit 94816e4

Browse files
committed
[I/Y-Build] Convert comparator-error message in mail to plain-text too
And simplify the creation of the comparator-error message in the result mail send to the mailing-list. Previously the message was still html-code. Follow-up on - #2711
1 parent b770afd commit 94816e4

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

JenkinsJobs/Builds/build.jenkinsfile

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,6 @@ spec:
275275
script {
276276
def buildProps = readBuildProperties("${CJE_ROOT}/buildproperties.properties")
277277
env.COMPARATOR_ERRORS_SUBJECT = buildProps.COMPARATOR_ERRORS_SUBJECT
278-
env.COMPARATOR_ERRORS_BODY = buildProps.COMPARATOR_ERRORS_BODY
279278
}
280279
}
281280
}
@@ -359,22 +358,25 @@ spec:
359358
}
360359
success {
361360
emailext subject: "${RELEASE_VER} ${BUILD_TYPE}-Build: ${BUILD_IID} ${COMPARATOR_ERRORS_SUBJECT}",
362-
body: """\
361+
body: ("""\
363362
Eclipse downloads:
364363
https://download.eclipse.org/eclipse/downloads/drops4/${BUILD_IID}
365364

366365
Build logs and/or test results (eventually):
367366
https://download.eclipse.org/eclipse/downloads/drops4/${BUILD_IID}/testResults.php
368-
369-
${COMPARATOR_ERRORS_BODY}Software site repository:
367+
""" + (env.COMPARATOR_ERRORS_SUBJECT == '' ? '' : """
368+
Check unanticipated comparator messages:
369+
https://download.eclipse.org/eclipse/downloads/drops4/${BUILD_IID}/buildlogs/comparatorlogs/buildtimeComparatorUnanticipated.log.txt
370+
""") + """
371+
Software site repository:
370372
https://download.eclipse.org/eclipse/updates/${RELEASE_VER}-${BUILD_TYPE}-builds
371373

372374
Specific (simple) site repository:
373375
https://download.eclipse.org/eclipse/updates/${RELEASE_VER}-${BUILD_TYPE}-builds/${BUILD_IID}
374376

375377
Equinox downloads:
376378
https://download.eclipse.org/equinox/drops/${BUILD_IID}
377-
""".stripIndent(), mimeType: 'text/plain',
379+
""").stripIndent(), mimeType: 'text/plain',
378380
to: "${BUILD.mailingList}", from:'[email protected]'
379381
}
380382
}

cje-production/mbscripts/mb300_gatherEclipseParts.sh

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -282,10 +282,8 @@ then
282282

283283
fn-write-property COMPARATOR_ERRORS "true"
284284
fn-write-property COMPARATOR_ERRORS_SUBJECT "\"- Comparator Errors Found\""
285-
fn-write-property COMPARATOR_ERRORS_BODY "\"Check unanticipated comparator messages:<br> <a href='https://download.eclipse.org/eclipse/downloads/drops4/${BUILD_ID}/buildlogs/comparatorlogs/buildtimeComparatorUnanticipated.log.txt'>https://download.eclipse.org/eclipse/downloads/drops4/${BUILD_ID}/buildlogs/comparatorlogs/buildtimeComparatorUnanticipated.log.txt</a><br><br>\""
286285
else
287286
echo -e "DEBUG: comparator logSize of $logSize was not greater than comparatorLogMinimumSize of ${comparatorLogMinimumSize}"
288287
fn-write-property COMPARATOR_ERRORS_SUBJECT "\"\""
289-
fn-write-property COMPARATOR_ERRORS_BODY "\"\""
290288
fi
291289

0 commit comments

Comments
 (0)