Skip to content

Commit c23bceb

Browse files
committed
[I-Build-Tests] Remove unused consideration of Java extension directory
For current I-build tests java.ext.dir is never specified.
1 parent ac4ffd3 commit c23bceb

File tree

6 files changed

+4
-59
lines changed

6 files changed

+4
-59
lines changed

production/testScripts/configuration/sdk.tests/testConfigs/linux/testAll.sh

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ eclipseArch=${eclipseArch:-x86_64}
3232
echo "=== properties in testAll.sh"
3333
echo " DOWNLOAD_HOST: ${DOWNLOAD_HOST}"
3434
echo " jvm in testAll: ${jvm}"
35-
echo " extdir in testAll (if any): ${extdir}"
3635
echo " propertyFile in testAll: ${propertyFile}"
3736
echo " buildId in testAll: ${buildId}"
3837
echo " testedPlatform: ${testedPlatform}"
@@ -44,10 +43,5 @@ cat ${propertyFile}
4443
/bin/chmod 755 runtests.sh
4544
/bin/mkdir -p results/consolelogs
4645

47-
if [[ -n "${extdir}" ]]
48-
then
49-
./runtests.sh -os linux -ws gtk -arch $eclipseArch -extdirprop "${extdir}" -vm "${jvm}" -properties ${propertyFile} "${@}" > results/consolelogs/${testedPlatform}_consolelog.txt
50-
else
51-
./runtests.sh -os linux -ws gtk -arch $eclipseArch -vm "${jvm}" -properties ${propertyFile} "${@}" > results/consolelogs/${testedPlatform}_consolelog.txt
52-
fi
46+
./runtests.sh -os linux -ws gtk -arch $eclipseArch -vm "${jvm}" -properties ${propertyFile} "${@}" > results/consolelogs/${testedPlatform}_consolelog.txt
5347

production/testScripts/configuration/sdk.tests/testConfigs/macosx/testAll.sh

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ eclipseArch=${eclipseArch:-x86_64}
3232
echo "=== properties in testAll.sh"
3333
echo " DOWNLOAD_HOST: ${DOWNLOAD_HOST}"
3434
echo " jvm in testAll: ${jvm}"
35-
echo " extdir in testAll (if any): ${extdir}"
3635
echo " propertyFile in testAll: ${propertyFile}"
3736
echo " buildId in testAll: ${buildId}"
3837
echo " testedPlatform: ${testedPlatform}"
@@ -44,9 +43,4 @@ cat ${propertyFile}
4443
/bin/chmod 755 runtestsmac.sh
4544
/bin/mkdir -p results/consolelogs
4645

47-
if [[ -n "${extdir}" ]]
48-
then
49-
./runtestsmac.sh -os macosx -ws cocoa -arch $eclipseArch -extdirprop "${extdir}" -vm "${jvm}" -properties ${propertyFile} $* > results/consolelogs/${testedPlatform}_consolelog.txt
50-
else
51-
./runtestsmac.sh -os macosx -ws cocoa -arch $eclipseArch -vm "${jvm}" -properties ${propertyFile} $* > results/consolelogs/${testedPlatform}_consolelog.txt
52-
fi
46+
./runtestsmac.sh -os macosx -ws cocoa -arch $eclipseArch -vm "${jvm}" -properties ${propertyFile} $* > results/consolelogs/${testedPlatform}_consolelog.txt

production/testScripts/configuration/sdk.tests/testConfigs/windows/testAll.bat

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ IF NOT DEFINED eclipseArch SET eclipseArch=x86_64
3030
ECHO === properties in testAll.bat
3131
ECHO DOWNLOAD_HOST: %DOWNLOAD_HOST%
3232
ECHO jvm in testAll: %jvm%
33-
ECHO extdir in testAll (if any): %extdir%
3433
ECHO propertyFile in testAll: %propertyFile%
3534
ECHO buildId in testAll: %buildId%
3635
ECHO testedPlatform: %testedPlatform%
@@ -40,11 +39,6 @@ mkdir results\consolelogs
4039

4140
set consolelogs=results\consolelogs\%testedPlatform%_consolelog.txt
4241

43-
IF DEFINED extdir (
44-
runtests.bat -extdirprop "%extdir%" -os win32 -ws win32 -arch %eclipseArch% -vm "%jvm%" -properties %propertyFile% %* > %consolelogs%
45-
GOTO END
46-
)
47-
4842
runtests.bat -os win32 -ws win32 -arch %eclipseArch% -vm "%jvm%" -properties %propertyFile% %* > %consolelogs%
4943

5044
:END

production/testScripts/configuration/sdk.tests/testScripts/runtests.bat

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -48,14 +48,11 @@ if x%1==x-arch set arch=%2 && shift && shift && goto processcmdlineargs
4848
if x%1==x-noclean set installmode=noclean&& shift && goto processcmdlineargs
4949
if x%1==x-properties set properties=-propertyfile %2 && shift && shift && goto processcmdlineargs
5050
if x%1==x-vm set jvm=%2 && shift && shift && goto processcmdlineargs
51-
if x%1==x-extdirprop SET extdirproperty="-Djava.ext.dirs=%2" && shift && shift && goto processcmdlineargs
52-
5351

5452

5553
set tests=%tests% %1 && shift && goto processcmdlineargs
5654

5755
echo Specified test targets (if any): %tests%
58-
echo Specified extdirs (if any): %extdirprop%
5956

6057
:run
6158
REM ***************************************************************************
@@ -77,11 +74,6 @@ exit 1
7774
REM -XshowSettings is supported on windows VMs but ... not every where. So where not supported
7875
REM causes VM to not start at all. Can be handy for diagnostics. (without running ant <echoproperties/>
7976

80-
IF DEFINED extdirproperty (
81-
%jvm% %ANT_OPTS% %extdirproperty% -Dosgi.os=%os% -Dosgi.ws=%ws% -Dosgi.arch=%arch% -jar eclipse\plugins\%launcher-jar% -data workspace -application org.eclipse.ant.core.antRunner -file test.xml %tests% -Dws=%ws% -Dos=%os% -Darch=%arch% -D%installmode%=true %properties% -logger org.apache.tools.ant.DefaultLogger
82-
GOTO END
83-
)
84-
8577
%jvm% %ANT_OPTS% -Dosgi.os=%os% -Dosgi.ws=%ws% -Dosgi.arch=%arch% -jar eclipse\plugins\%launcher-jar% -data workspace -application org.eclipse.ant.core.antRunner -file test.xml %tests% -Dws=%ws% -Dos=%os% -Darch=%arch% -D%installmode%=true %properties% -logger org.apache.tools.ant.DefaultLogger
8678

8779
:END

production/testScripts/configuration/sdk.tests/testScripts/runtests.sh

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,6 @@ installmode="clean"
7878
# name of a property file to pass to Ant
7979
properties=
8080

81-
# ext dir customization. Be sure "blank", if not defined explicitly on command line
82-
extdirproperty=
83-
8481
# message printed to console
8582
usage="usage: $0 -os <osType> -ws <windowingSystemType> -arch <architecture> [-noclean] [<test target>][-properties <path>]"
8683

@@ -101,8 +98,6 @@ do
10198
installmode="noclean";;
10299
-properties)
103100
properties="-propertyfile ${2}";shift;;
104-
-extdirprop)
105-
extdirproperty="-Djava.ext.dirs=${2}";shift;;
106101
-vm)
107102
jvm="${2}"; shift;;
108103
*)
@@ -113,8 +108,6 @@ done
113108

114109
echo "Specified test targets (if any): ${tests}"
115110

116-
echo "Specified ext dir (if any): ${extdirproperty}"
117-
118111
# for *nix systems, os, ws and arch values must be specified
119112
if [[ -z "${os}" || -z "${ws}" || -z "${arch}" ]]
120113
then
@@ -208,20 +201,11 @@ echo
208201

209202

210203
mkdir -p results/consolelogs
211-
echo "extdirprop in runtest.sh: ${extdirprop}"
212-
echo "extdirproperty in runtest.sh: ${extdirproperty}"
213204
echo "ANT_OPTS in runtests.sh: ${ANT_OPTS}"
214205
echo "DOWNLOAD_HOST: $DOWNLOAD_HOST"
215206
echo "platformArgString: ${platformArgString}"
216207
echo "platformParmString: ${platformParmString}"
217208
echo "platformString: ${platformString}"
218209
echo "testedPlatform: ${testedPlatform}"
219210

220-
if [[ -n "${extdirproperty}" ]]
221-
then
222-
echo "running with extdir defined"
223-
$jvm ${ANT_OPTS} "${extdirproperty}" ${platformArgString} -jar $launcher -data workspace -application org.eclipse.ant.core.antRunner -file ${PWD}/test.xml ${platformParmString} -D$installmode=true $properties -logger org.apache.tools.ant.DefaultLogger $tests
224-
else
225-
echo "running without extdir defined"
226-
$jvm ${ANT_OPTS} ${platformArgString} -jar $launcher -data workspace -application org.eclipse.ant.core.antRunner -file ${PWD}/test.xml ${platformParmString} -D$installmode=true $properties -logger org.apache.tools.ant.DefaultLogger $tests
227-
fi
211+
$jvm ${ANT_OPTS} ${platformArgString} -jar $launcher -data workspace -application org.eclipse.ant.core.antRunner -file ${PWD}/test.xml ${platformParmString} -D$installmode=true $properties -logger org.apache.tools.ant.DefaultLogger $tests

production/testScripts/configuration/sdk.tests/testScripts/runtestsmac.sh

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,6 @@ installmode="clean"
3636
# name of a property file to pass to Ant
3737
properties=
3838

39-
# ext dir customization. Be sure "blank", if not defined explicitly on command line
40-
extdirproperty=
41-
4239
# message printed to console
4340
usage="usage: $0 -os <osType> -ws <windowingSystemType> -arch <architecture> [-noclean] [<test target>][-properties <path>]"
4441

@@ -59,8 +56,6 @@ do
5956
installmode="noclean";;
6057
-properties)
6158
properties="-propertyfile ${2}";shift;;
62-
-extdirprop)
63-
extdirproperty="-Djava.ext.dirs=${2}";shift;;
6459
-vm)
6560
jvm="${2}"; shift;;
6661
*)
@@ -71,8 +66,6 @@ done
7166

7267
echo "Specified test targets (if any): ${tests}"
7368

74-
echo "Specified ext dir (if any): ${extdirproperty}"
75-
7669
# for *nix systems, os, ws and arch values must be specified
7770
if [ "x$os" = "x" ]
7871
then
@@ -131,11 +124,5 @@ fi
131124

132125
echo "properties: $properties"
133126

134-
if [[ ! -z "${extdirproperty}" ]]
135-
then
136-
$jvm ${ANT_OPTS} "${extdirproperty}" -Dosgi.os=$os -Dosgi.ws=$ws -Dosgi.arch=$arch -jar $launcher -data workspace -application org.eclipse.ant.core.antRunner -file ${PWD}/test.xml $tests -Dws=$ws -Dos=$os -Darch=$arch -D$installmode=true $properties -logger org.apache.tools.ant.DefaultLogger
137-
else
138-
$jvm ${ANT_OPTS} -Dosgi.os=$os -Dosgi.ws=$ws -Dosgi.arch=$arch -jar $launcher -data workspace -application org.eclipse.ant.core.antRunner -file ${PWD}/test.xml $tests -Dws=$ws -Dos=$os -Darch=$arch -D$installmode=true $properties -logger org.apache.tools.ant.DefaultLogger
139-
fi
140-
127+
$jvm ${ANT_OPTS} -Dosgi.os=$os -Dosgi.ws=$ws -Dosgi.arch=$arch -jar $launcher -data workspace -application org.eclipse.ant.core.antRunner -file ${PWD}/test.xml $tests -Dws=$ws -Dos=$os -Darch=$arch -D$installmode=true $properties -logger org.apache.tools.ant.DefaultLogger
141128

0 commit comments

Comments
 (0)