[Build] Use String.strip() instead of trim()

This also reverts "Use trim() instead of strip() because Jenkins doesn't
like it now."

This reverts commit 0cc3c77.

Author: HannesWell

JenkinsJobs/Builds/build.jenkinsfile

@@ -344,7 +344,7 @@ spec:
 
 def readBuildProperties(String buildPropertiesFile){
 	return readProperties(file: buildPropertiesFile, charset: 'UTF-8').collectEntries{n, v ->
-			v = v.trim();
+			v = v.strip();
 			return [n, (v.startsWith('"') && v.endsWith('"') ? v.substring(1, v.length() - 1) : v)]
 		}
 }

JenkinsJobs/Releng/publishToMaven.jenkinsfile

@@ -266,7 +266,7 @@ def installLatestEclipse(){
 	def props = null
 	dir("${WORKSPACE}/git-repo") {
 		props = readProperties(file: 'cje-production/buildproperties.txt').collectEntries{n, v ->
-				v = v.trim();
+				v = v.strip();
 				return [n, (v.startsWith('"') && v.endsWith('"') ? v.substring(1, v.length() - 1) : v)]
 			}
 	}
@@ -276,6 +276,6 @@ def installLatestEclipse(){
 def install(String toolType, String url) {
 	dir("${WORKSPACE}/tools/${toolType}") {
 		sh "curl -L ${url} | tar -xzf -"
-		return "${pwd()}/" + sh(script: 'ls', returnStdout: true).trim()
+		return "${pwd()}/" + sh(script: 'ls', returnStdout: true).strip()
 	}
 }

JenkinsJobs/SmokeTests/StartSmokeTests.jenkinsfile

@@ -158,6 +158,6 @@ def installJDK(String version, String os, String arch, String releaseType='ga')
 	}
 	dir ("${WORKSPACE}/java") {
 		sh "curl -L https://api.adoptium.net/v3/binary/latest/${version}/${releaseType}/${os}/${arch}/jdk/hotspot/normal/eclipse | tar -xzf -"
-		return "${pwd()}/" + sh(script: 'ls', returnStdout: true).trim()
+		return "${pwd()}/" + sh(script: 'ls', returnStdout: true).strip()
 	}
 }

Jenkinsfile

@@ -43,7 +43,7 @@ pipeline {
 							latestCommitID=$(curl https://download.eclipse.org/eclipse/relengScripts/state)
 							git diff --name-only ${latestCommitID} HEAD \\
 								production/ scripts/ cje-production/ eclipse.platform.releng.tychoeclipsebuilder/
-							''', returnStdout: true).trim().isEmpty()
+							''', returnStdout: true).strip().isEmpty()
 					}
 				}
 			}