Skip to content

Commit ffcd48a

Browse files
committed
[Build|GH] Unify Maven arguments and don't fail on test-failures
In the shared GH workflows use long option names to be more readable. Also don't fail the build on test-failures because the the additional test-result check fails in case of test-failures. This simplifies the distinction between 'hard' failures, like compile-errors and test-failures.
1 parent 420686a commit ffcd48a

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

.github/workflows/codeQLworkflow.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,9 +93,8 @@ jobs:
9393
uses: coactions/setup-xvfb@6b00cf1889f4e1d5a48635647013c0508128ee1a
9494
with:
9595
run: >-
96-
mvn --batch-mode -V -U
96+
mvn --batch-mode --no-transfer-progress --show-version --update-snapshots --errors
9797
${{ inputs.without-EF-infra && '-Dtycho.version=4.0.12' || '' }}
98-
-ntp
9998
-Dcompare-version-with-baselines.skip=true
10099
-Pbree-libs
101100
-DskipTests=true

.github/workflows/mavenBuild.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,13 +91,12 @@ jobs:
9191
uses: coactions/setup-xvfb@6b00cf1889f4e1d5a48635647013c0508128ee1a
9292
with:
9393
run: >-
94-
mvn --batch-mode -V -U -e
94+
mvn --batch-mode --no-transfer-progress --show-version --update-snapshots --errors
9595
${{ inputs.without-EF-infra && '-Dtycho.version=4.0.12' || '' }}
96-
-ntp
9796
-Dcompare-version-with-baselines.skip=false
9897
-Pbree-libs
9998
-Papi-check
100-
--fail-at-end
99+
--fail-at-end -Dmaven.test.failure.ignore=true
101100
${{ inputs.maven-goals }}
102101
- name: Upload Test Results for ${{ matrix.config.name }}
103102
if: always()

0 commit comments

Comments
 (0)