How to solve: " The 'final' keyword has been added ..."

[fedejeanne]

Hi have 2 errors saying that the word final has been added (API change) and that the major version should be incremented:

Here are the descriptions, for reference:

1. The 'final' keyword has been added for the method org.eclipse.jdt.ui.text.folding.DefaultJavaFoldingStructureProvider.alignRegion(IRegion, DefaultJavaFoldingStructureProvider.FoldingStructureComputationContext)
2. The major version should be incremented in version 3.34.0, since API breakage occurred since version 3.33.200

And here's the method signature:

protected final IRegion alignRegion(IRegion region, FoldingStructureComputationContext ctx)

These errors only show up sometimes and then they go away. I still don't know how they go away though and I would like to remedy them on my own so I don't have to see them in the first place.

Some other details:

• This doesn't happen in all my workspaces
• I already tried incrementing the Bundle-Version in the MANIFEST just to force some API check. It didn't work.
• I also tried modifying the forceQualifierUpdate.txt, just for fun. It didn't work either.
• Removing the word final makes both errors disappear
• Removing the word final in another (non-broken) workspace with the same projects in the same state does not generate any errors, though I think it should.

Does anyone know why do these errors even show up and how can I get rid of them?

Bonus question: shouldn't there be a new error when I remove the word final in the other workspace?

Thank you in advance for your help.

[mickaelistria]

What's the version for org.eclipse.jdt.ui in your API baseline?
It looks like this code was introduced last week, so this method shouldn't even be checked for API compatibility as baseline is not supposed to have it.

[fedejeanne]

Where can I check the version?

[HeikoKlare]

[fedejeanne]

Thank you. It's 3.33.200

[merks]

It was added by this commit without an @since but I think protected methods of API classes are API...

eclipse-jdt/eclipse.jdt.ui@28604fa#diff-7f2913e0f13045dcd89bf949b4b0a258b6acabf390b2971b60b78394915da497

[merks]

Indeed. Here's what I do when there seem to be strange API problems that I hope will go away:

I.e., edit and refresh, then it wants to do a full build when you do apply:

[fedejeanne]

Edit and refresh (+ build) didn't help, the errors are still there.

[merks]

Restart and repeat?

[merks]

Moving methods around is not so helpful for understanding history. In any case that method has existed as a final method for a very long time so the error is bogus and you have to wonder from where does it (API tools) find a version that wasn't final?

[fedejeanne]

Restart and repeat?

I restarted Eclipse and did it again: didn't help

Moving methods around is not so helpful for understanding history.

Agreed, I missed that during the review. I'll keep it in mind for the next one :-)