add preference help for custom folding regions #2703
Conversation
...ndles/org.eclipse.jdt.doc.user/reference/preferences/java/editor/ref-preferences-folding.htm
Outdated
Show resolved
Hide resolved
danthe1st
force-pushed
the
custom-folding-regions
branch
from
2f4537b to
cce50a6
Compare
|
@danthe1st this is still marked as draft. Is there anything pending on your end preventing a merge? |
The PR introducing this feature is still open: eclipse-jdt/eclipse.jdt.ui#1825 Until the feature is actually merged, I don't think there's a point in merging the PR to the help. |
danthe1st
force-pushed
the
custom-folding-regions
branch
from
cce50a6 to
de93443
Compare
|
@danthe1st Now that it has been merged in jdt, please fix the merge conflict . |
danthe1st
force-pushed
the
custom-folding-regions
branch
3 times, most recently
from
0b93fd9 to
3cbfbcb
Compare
|
For now, I updated this PR following the format introduced in #2826: Alternatively, I could do it in a similar way to the content assist preferences with headings: Another option is using indentation for the Region start/end text entries but I am unsure about using indentation for text inputs. |
|
@akurtakov Will do |
|
Hi @akurtakov The content being added is correct and matches the new options/behavior. |
akurtakov
force-pushed
the
custom-folding-regions
branch
from
3cbfbcb to
9cc3e48
Compare
danthe1st
force-pushed
the
custom-folding-regions
branch
from
9cc3e48 to
af977ce
Compare
|
^ bumped the version to make the build pass |
danthe1st
force-pushed
the
custom-folding-regions
branch
from
af977ce to
16fc39e
Compare
akurtakov
dismissed
BeckerWdf’s stale review
I believe your request have been fullfilled and you haven't acted on the PR for long period thus dismissing your review.
5 participants
This PR contains the help page update for eclipse-jdt/eclipse.jdt.ui#1825.