I20250408-1800 - BUILD FAILED

[iloveeclipse]

See https://ci.eclipse.org/releng/job/Builds/job/I-build-4.36/51/console

Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:4.0.13-SNAPSHOT:compile (default-compile) on project org.eclipse.equinox.p2.metadata: Compilation failure: Compilation failure: 
00:10:50  [ERROR] /home/jenkins/agent/workspace/Builds/I-build-4.36/cje-production/gitCache/eclipse.platform.releng.aggregator/equinox.p2/bundles/org.eclipse.equinox.p2.metadata/src/org/eclipse/equinox/p2/query/QueryUtil.java:[185] 
00:10:50  [ERROR] 	return createCompoundQuery(queries, and);
00:10:50  [ERROR] 	       ^^^^^^^^^^^^^^^^^^^
00:10:50  [ERROR] The method createCompoundQuery(Collection<? extends IQuery<? extends T>>, boolean) in the type QueryUtil is not applicable for the arguments (ArrayList<IQuery<? extends T>>, boolean)
00:10:50  [ERROR] /home/jenkins/agent/workspace/Builds/I-build-4.36/cje-production/gitCache/eclipse.platform.releng.aggregator/equinox.p2/bundles/org.eclipse.equinox.p2.metadata/src/org/eclipse/equinox/p2/query/QueryUtil.java:[460] 
00:10:50  [ERROR] 	return createPipeQuery(queries);
00:10:50  [ERROR] 	       ^^^^^^^^^^^^^^^
00:10:50  [ERROR] The method createPipeQuery(Collection<? extends IQuery<? extends T>>) in the type QueryUtil is not applicable for the arguments (ArrayList<IQuery<? extends T>>)
00:10:50  [ERROR] 10 problems (2 errors, 8 warnings)

Most likely regression from eclipse-jdt/eclipse.jdt.core#3910 (I haven't verified yet).

@srikanth-sankaran , @stephan-herrmann : could you please check?

[iloveeclipse]

Most likely regression from eclipse-jdt/eclipse.jdt.core#3910 (I haven't verified yet).

It is a regression from this PR. The question is now whether the code in p2 or in jdt has to be fixed.

Compiler reports errors for these lines:

https://github.com/eclipse-equinox/p2/blob/eaf4474803143615af5689d8663e7e9bd1d6d775/bundles/org.eclipse.equinox.p2.metadata/src/org/eclipse/equinox/p2/query/QueryUtil.java#L185

https://github.com/eclipse-equinox/p2/blob/eaf4474803143615af5689d8663e7e9bd1d6d775/bundles/org.eclipse.equinox.p2.metadata/src/org/eclipse/equinox/p2/query/QueryUtil.java#L460

[iloveeclipse]

Note: with the patch below both compilers can compile the code in question:

diff --git a/bundles/org.eclipse.equinox.p2.metadata/src/org/eclipse/equinox/p2/query/QueryUtil.java b/bundles/org.eclipse.equinox.p2.metadata/src/org/eclipse/equinox/p2/query/QueryUtil.java
index a239f55..abc9fa2 100644
--- a/bundles/org.eclipse.equinox.p2.metadata/src/org/eclipse/equinox/p2/query/QueryUtil.java
+++ b/bundles/org.eclipse.equinox.p2.metadata/src/org/eclipse/equinox/p2/query/QueryUtil.java
@@ -98,7 +98,7 @@
 	 * @return A compound query
 	 */
 	@SuppressWarnings("unchecked")
-	public static <T> IQuery<T> createCompoundQuery(Collection<? extends IQuery<? extends T>> queries, boolean and) {
+	public static <T> IQuery<T> createCompoundQuery(Collection<IQuery<? extends T>> queries, boolean and) {
 		IExpressionFactory factory = ExpressionUtil.getFactory();
 		int top = queries.size();
 		if (top == 1) {
@@ -425,7 +425,7 @@
 	 * @return A query pipe
 	 */
 	@SuppressWarnings("unchecked")
-	public static <T> IQuery<T> createPipeQuery(Collection<? extends IQuery<? extends T>> queries) {
+	public static <T> IQuery<T> createPipeQuery(Collection<IQuery<? extends T>> queries) {
 		IExpressionFactory factory = ExpressionUtil.getFactory();
 		int top = queries.size();
 		IExpression[] expressions = new IExpression[top];

but we have compiler errors in other places that use changed code : IUDescription and MirrorTask

[iloveeclipse]

Here is the full patch for the code that compiles in both compiler

diff --git a/bundles/org.eclipse.equinox.p2.metadata/src/org/eclipse/equinox/p2/query/QueryUtil.java b/bundles/org.eclipse.equinox.p2.metadata/src/org/eclipse/equinox/p2/query/QueryUtil.java
index a239f55..a9a7c4b 100644
--- a/bundles/org.eclipse.equinox.p2.metadata/src/org/eclipse/equinox/p2/query/QueryUtil.java
+++ b/bundles/org.eclipse.equinox.p2.metadata/src/org/eclipse/equinox/p2/query/QueryUtil.java
@@ -98,11 +98,11 @@
 	 * @return A compound query
 	 */
 	@SuppressWarnings("unchecked")
-	public static <T> IQuery<T> createCompoundQuery(Collection<? extends IQuery<? extends T>> queries, boolean and) {
+	public static <T> IQuery<T> createCompoundQuery(Collection<IQuery<T>> queries, boolean and) {
 		IExpressionFactory factory = ExpressionUtil.getFactory();
 		int top = queries.size();
 		if (top == 1) {
-			return (IQuery<T>) queries.iterator().next();
+			return queries.iterator().next();
 		}
 
 		Class<? extends T> elementClass = (Class<T>) Object.class;
@@ -178,8 +178,8 @@
 	 * a logical 'or'.
 	 * @return A compound query
 	 */
-	public static <T> IQuery<T> createCompoundQuery(IQuery<? extends T> query1, IQuery<T> query2, boolean and) {
-		ArrayList<IQuery<? extends T>> queries = new ArrayList<>(2);
+	public static <T> IQuery<T> createCompoundQuery(IQuery<T> query1, IQuery<T> query2, boolean and) {
+		ArrayList<IQuery<T>> queries = new ArrayList<>(2);
 		queries.add(query1);
 		queries.add(query2);
 		return createCompoundQuery(queries, and);
@@ -425,7 +425,7 @@
 	 * @return A query pipe
 	 */
 	@SuppressWarnings("unchecked")
-	public static <T> IQuery<T> createPipeQuery(Collection<? extends IQuery<? extends T>> queries) {
+	public static <T> IQuery<T> createPipeQuery(Collection<IQuery<T>> queries) {
 		IExpressionFactory factory = ExpressionUtil.getFactory();
 		int top = queries.size();
 		IExpression[] expressions = new IExpression[top];
@@ -453,8 +453,8 @@
 	 * @param query2 the second query
 	 * @return A query pipe
 	 */
-	public static <T> IQuery<T> createPipeQuery(IQuery<? extends T> query1, IQuery<? extends T> query2) {
-		ArrayList<IQuery<? extends T>> queries = new ArrayList<>(2);
+	public static <T> IQuery<T> createPipeQuery(IQuery<T> query1, IQuery<T> query2) {
+		ArrayList<IQuery<T>> queries = new ArrayList<>(2);
 		queries.add(query1);
 		queries.add(query2);
 		return createPipeQuery(queries);

[iloveeclipse]

I've pushed eclipse-equinox/p2#785 to see whether there will be anything broken with Jenkins compilation which I don't see locally in the IDE.

[srikanth-sankaran]

It is a regression from this PR. The question is now whether the code in p2 or in jdt has to be fixed.

Compiler reports errors for these lines:

I think @stephan-herrmann is the right person to take a call on how to move forward - It is too intricate for someone who didn't work on it.

@stephan-herrmann - what is your advice ? If you need more time, I can arrange for a revert for the time being so we have a stable build until full investigation is complete and we have a fix.

Here is the full patch for the code that compiles in both compiler

While this may allow us to get past the build error, a determination has to be made as to whether the fix itself is good.

[iloveeclipse]

While this may allow us to get past the build error, a determination has to be made as to whether the fix itself is good.

Sure, I only wanted to provide this as information and possible alternative to revert of compiler changes.
Note, the proposed p2 patch is changing API, although it should be binary compatible if I see it right.

[srikanth-sankaran]

FWIW, I have created eclipse-jdt/eclipse.jdt.core#3913 to temporarily revert eclipse-jdt/eclipse.jdt.core#3910 just in case @stephan-herrmann is unable to find time today.