-
Notifications
You must be signed in to change notification settings - Fork 90
Add a profile to enable compilation with javac #2983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sometimes there is a question "does it compile with javac" and doing so by hand can become cumbersome. This now adds a new profile "javac" that can be used to enable javac as a compiler instead of ecj and disable baseline compare/replace because of javac emits different bytecode by default.
0bf7f10 to
e3076cc
Compare
|
@laeubi : for non-maven users, could you provide maven commands to use (for both SDK aggregator and for a single project)? |
|
Build failure is unrelated. @iloveeclipse for any usual build simply add
|
akurtakov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It wouldn't hurt to have this one to make testing easier.
|
Have you seen that the code doesn't compil, but it doesn't compile in a different place? https://ci.eclipse.org/platform/job/eclipse.platform.releng.aggregator/job/PR-2983/2/console |
|
That is the same failure as before my change (see master build), the Jenkins job uses parallel execution, as that it might compile in different order depending on how many CPU time is there. So I think this shows not only P2 is affected. |
|
Here is also a CI job using that new profile: it currently fails to upload the event-file twice, but the jobs itself are running.... |
Sometimes there is a question "does it compile with javac" and doing so by hand can become cumbersome.
This now adds a new profile "javac" that can be used to enable javac as a compiler instead of ecj and disable baseline compare/replace because of javac emits different bytecode by default.