Dependency Updates #2988
Merged
Dependency Updates #2988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@HeikoKlare Usually deps updates are something that we merge eagerly. Should we be extra careful with jsvg or it should be treated like everything else? |
Contributor
|
I think we should treat it like everything else. Maybe we should be a bit careful when merging late in a development cycle, so that in case there might be regressions we have a chance to find them. Once all PNG icons are replaced with SVGs, I would expect regressions to be detected soon by implicit usage of a new version after the dependency update. |
Member
|
Merging as per previous comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The content of the target
eclipse-sdk-prereqs.targetwas updatedPlease review the changes and merge if appropriate, or cherry pick individual updates.
The following maven artifacts have been updated:
com.github.weisj:jsvg:jar:1.7.1has been updated to version1.7.2