Comparator errors in I20250423-0410

[iloveeclipse]

See

• https://download.eclipse.org/eclipse/downloads/drops4/I20250423-0410/
• https://download.eclipse.org/eclipse/downloads/drops4/I20250423-0410/buildlogs/comparatorlogs/buildtimeComparatorUnanticipated.log.txt

omparator differences from current build
	/home/jenkins/agent/workspace/Builds/I-build-4.36/cje-production/siteDir/eclipse/downloads/drops4/I20250423-0410
compared to reference repo at 
	https://download.eclipse.org/eclipse/updates/4.36-I-builds/

1.  eclipse.platform/runtime/bundles/org.eclipse.e4.core.di/.polyglot.META-INF
   no-classifier: different
      org/eclipse/e4/core/internal/di/AnnotationLookup$AnnotationProxy.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

2.  eclipse.platform.ui/bundles/org.eclipse.e4.ui.workbench/.polyglot.META-INF
   no-classifier: different
      org/eclipse/e4/ui/internal/workbench/ModelAssembler$FragmentWrapperElementMapping.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

3.  eclipse.platform/ua/org.eclipse.help/pom.xml
   no-classifier: different
      org/eclipse/help/internal/util/SequenceResolver$ListWithIterator.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

4.  eclipse.platform/resources/bundles/org.eclipse.core.resources/.polyglot.META-INF
   no-classifier: different
      org/eclipse/core/internal/utils/Cache$Entry.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

5.  eclipse.platform.ui/bundles/org.eclipse.jface.text/.polyglot.META-INF
   no-classifier: different
      org/eclipse/jface/text/source/inlined/InlinedAnnotationDrawingStrategy$GCConfig.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

6.  equinox.p2/bundles/org.eclipse.equinox.p2.publisher.eclipse/.tycho-consumer-pom.xml
   no-classifier: different
      org/eclipse/equinox/internal/p2/publisher/eclipse/MacOsBundleUrlType.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

7.  eclipse.jdt.debug/org.eclipse.jdt.debug/.polyglot.META-INF
   no-classifier: different
      jdimodel.jar: different
         org/eclipse/jdt/debug/core/IJavaStackFrame$Category.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

8.  eclipse.platform.ui/bundles/org.eclipse.ui.editors/.polyglot.META-INF
   no-classifier: different
      org/eclipse/ui/internal/texteditor/stickyscroll/IStickyLinesProvider$StickyLinesProperties.class: different
      org/eclipse/ui/internal/texteditor/stickyscroll/StickyScrollingControlSettings.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

9.  eclipse.jdt.ui/org.eclipse.jdt.core.manipulation/.polyglot.META-INF
   no-classifier: different
      org/eclipse/jdt/core/manipulation/internal/javadoc/CoreJavaDoc2HTMLTextReader$Pair.class: different
      org/eclipse/jdt/core/manipulation/internal/javadoc/CoreJavadocAccess$SuperclassReferenceMethodData.class: different
      org/eclipse/jdt/internal/corext/fix/LambdaExpressionsFixCore$MethodInvocationStatus.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

10.  eclipse.pde/ui/org.eclipse.pde.core/.polyglot.META-INF
   no-classifier: different
      org/eclipse/pde/internal/core/ClasspathComputer$ClasspathConfiguration.class: different
      org/eclipse/pde/internal/core/FeatureTable$Idver.class: different
      org/eclipse/pde/internal/core/P2Utils$ProductInfo.class: different
      org/eclipse/pde/internal/core/PDEClasspathContainer$Rule.class: different
      org/eclipse/pde/internal/core/SourceLocationKey.class: different
      org/eclipse/pde/internal/core/builders/SourceEntryErrorReporter$1MissingOutputEntry.class: different
      org/eclipse/pde/internal/core/builders/SourceEntryErrorReporter$EncodingEntry.class: different
      org/eclipse/pde/internal/core/project/BundleProjectService$HostDescription.class: different
      org/eclipse/pde/internal/core/project/BundleProjectService$PackageExportDescription.class: different
      org/eclipse/pde/internal/core/project/BundleProjectService$PackageImportDescription.class: different
      org/eclipse/pde/internal/core/project/BundleProjectService$RequiredBundleDescription.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

11.  eclipse.jdt.debug/org.eclipse.jdt.debug.ui/pom.xml
   no-classifier: different
      org/eclipse/jdt/internal/debug/ui/StackFrameCategorizer$Filters.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

12.  eclipse.pde/apitools/org.eclipse.pde.api.tools/.polyglot.META-INF
   no-classifier: different
      org/eclipse/pde/api/tools/internal/builder/RequiredPackageVersionChange.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

13.  eclipse.pde/ui/org.eclipse.pde.bnd.ui/.polyglot.META-INF
   no-classifier: different
      org/eclipse/pde/bnd/ui/plugins/RepositoriesViewRefresher$WorkspaceTreeViewerRefreshModel.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

14.  eclipse.pde/ui/org.eclipse.pde.ui/.polyglot.META-INF
   no-classifier: different
      org/eclipse/pde/internal/ui/editor/bnd/BndBuildPathAutoCompleteProcessor$Prefix.class: different
      org/eclipse/pde/internal/ui/editor/bnd/BndBuildPathAutoCompleteProcessor$Value.class: different
      org/eclipse/pde/internal/ui/launcher/TracingBlock$PageBookKey.class: different
      org/eclipse/pde/internal/ui/launcher/TracingBlock$TracingOptionsManagerDelegate.class: different
      org/eclipse/pde/internal/ui/shared/target/IUContentProvider$IUWrapper.class: different
      org/eclipse/pde/internal/ui/shared/target/RepositoryBundleContainerAdapterFactory$RequirementNode.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

15.  eclipse.pde/ui/org.eclipse.pde.genericeditor.extension/.polyglot.META-INF
   no-classifier: different
      org/eclipse/pde/internal/genericeditor/target/extension/model/RepositoryCache$RepositoryMetadata.class: different
      org/eclipse/pde/internal/genericeditor/target/extension/p2/P2Fetcher$RepositoryContent.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

16.  eclipse.pde/ds/org.eclipse.pde.ds.annotations/.polyglot.META-INF
   no-classifier: different
      org/eclipse/pde/ds/internal/annotations/ComponentActivationAnnotation.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

17.  eclipse.platform.ui/bundles/org.eclipse.text.quicksearch/.polyglot.META-INF
   no-classifier: different
      org/eclipse/text/quicksearch/internal/core/ResourceWalker$QItem.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

18.  eclipse.platform.ui/tests/org.eclipse.jface.text.tests/.polyglot.META-INF
   no-classifier: different
      org/eclipse/jface/text/tests/TestWhitespaceCharacterPainter$DrawStringParams.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

19.  equinox/bundles/org.eclipse.equinox.transforms.hook/.polyglot.META-INF
   no-classifier: different
      org/eclipse/equinox/internal/transforms/TransformerBundleExtender$TransformerInfo.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

20.  eclipse.jdt.ui/org.eclipse.jdt.ui.tests/pom.xml
   no-classifier: different
      org/eclipse/jdt/junit/tests/JUnit5TestFinderJupiterTest$TestScenario.class: different
      org/eclipse/jdt/junit/tests/JUnitTestFinderTest$TestScenario.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

21.  eclipse.platform/runtime/tests/org.eclipse.e4.core.tests/pom.xml
   no-classifier: different
      org/eclipse/e4/core/internal/tests/di/InjectBridgeTest$Concrete.class: different
      org/eclipse/e4/core/internal/tests/nls/BundleMessagesRegistry.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

22.  eclipse.platform/ant/org.eclipse.ant.tests.ui/.polyglot.META-INF
   no-classifier: different
      anttestsui.jar: different
         org/eclipse/ant/tests/ui/RunInSeparateThreadRule$Result.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

Most likely result of JDT compiler changes eclipse-jdt/eclipse.jdt.core#3928 and eclipse-jdt/eclipse.jdt.core#3936.

[iloveeclipse]

I plan to analyze the bytecode and touch affected bundles in ~ 1 hour from now (I urgently need a lunch).

If someone wants, feel free to create PR's for affected bundles but please don't merge yet, as we don't know yet whether bytecode changes are expected.

[srikanth-sankaran]

eclipse.jdt.debug entries look fine,

7. eclipse.jdt.debug/org.eclipse.jdt.debug/.polyglot.META-INF
   no-classifier: different
   jdimodel.jar: different
   org/eclipse/jdt/debug/core/IJavaStackFrame$Category.class: different
   The main artifact has been replaced with the baseline version.
   The following attached artifacts have been replaced with the baseline version: [sources]

11. eclipse.jdt.debug/org.eclipse.jdt.debug.ui/pom.xml
    no-classifier: different
    org/eclipse/jdt/internal/debug/ui/StackFrameCategorizer$Filters.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

[srikanth-sankaran]

@jarthana - I have analyzed more than 50% of the classes that differ - all are due to my changes and all look good so far - so you can save yourself the trouble - I will study the rest and will pull you in if absolutely necessary

[srikanth-sankaran]

I have studied all the 43 differing class files. All but these 4 files look fine.

Note: The ones below need a closer look - there is no indication that there is anything amiss

./eclipse.platform/runtime/bundles/org.eclipse.e4.core.di/target/artifactcomparison/no-classifier/org/eclipse/e4/core/internal/di/AnnotationLookup$AnnotationProxy.class-build

./eclipse.platform/runtime/tests/org.eclipse.e4.core.tests/target/artifactcomparison/no-classifier/org/eclipse/e4/core/internal/tests/di/InjectBridgeTest$Concrete.class-build

./eclipse.platform/runtime/tests/org.eclipse.e4.core.tests/target/artifactcomparison/no-classifier/org/eclipse/e4/core/internal/tests/nls/BundleMessagesRegistry.class-build

./eclipse.platform.ui/bundles/org.eclipse.e4.ui.workbench/target/artifactcomparison/no-classifier/org/eclipse/e4/ui/internal/workbench/ModelAssembler$FragmentWrapperElementMapping.class-build