Skip to content

Conversation

@HannesWell
Copy link
Member

@HannesWell HannesWell commented Apr 26, 2025

In order to mitigate the current outage of the EF-hosted storage, which will probably continue to block builds for at least a few days (https://www.eclipse.org/lists/eclipse.org-committers/msg01493.html) this implements a quick-fix to avoid the need for said EF infrastructure for the shared GitHub workflows. This is achieved by the following actions:

  • Obtain the eclipse-parent pom.xml and the sdk.target project from the GH repository and install it within the build into the local Maven cache
  • Revert Tycho to use it's latest release 4.0.12, which is available from Maven-Central

Especially the latter could cause problems for builds that rely on the new features only available in Tycho 4.0.13-SNAPSHOT. Therefore this is currently designed as opt-in feature. But looking at #2870 (comment), only SWT currently needs the snapshot but doesn't use the shared workflow.
After some more testing we could also enable this by default.

Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great workaround, thank you! 🚀

The change looks good and seems to work (as you show at the platform.ui repo). I only found a nitpicky typo, which you might fix in all three workflows when exchanging the organization name for the used action for final submission.

@HannesWell HannesWell force-pushed the gh-workflow-quickfix branch from ed6f684 to d91eb7d Compare April 26, 2025 12:20
@HannesWell
Copy link
Member Author

Thank you. I'm looking forward too!
The first jobs using this have succeeds in the testing PRs, some are still running but are looking good:

I just made the final adjustments to use the final repo and branch name, so this is ready for submission.
My intention is to submit this, as soon as all jobs have succeeded in the mentioned PRs.

@HannesWell HannesWell marked this pull request as ready for review April 26, 2025 12:24
@HannesWell HannesWell merged commit 420686a into eclipse-platform:master Apr 26, 2025
4 of 5 checks passed
@HannesWell HannesWell deleted the gh-workflow-quickfix branch April 26, 2025 12:40
HannesWell added a commit to HannesWell/eclipse.platform.releng.aggregator that referenced this pull request May 1, 2025
HannesWell added a commit that referenced this pull request May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants