Skip to content

Conversation

@merks
Copy link
Contributor

@merks merks commented May 1, 2025

No description provided.

@merks merks merged commit 0cc3c77 into eclipse-platform:master May 1, 2025
5 checks passed
@merks merks deleted the pr-strip-trim branch May 1, 2025 07:40
@merks
Copy link
Contributor Author

merks commented May 1, 2025

I previously tested this with a replay.

@HannesWell
Copy link
Member

We have to be careful with this as trim() only removes blank spaces while strip() removes all kind of white space. And sometimes the called CLI tools also include a line-break to beautify their output.
Therefore I requested the permission of String.strip() back then, in https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/2936
I hope it's added back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants