Skip to content

Conversation

@laeubi
Copy link
Contributor

@laeubi laeubi commented May 6, 2025

Since we migrated it from CDT, there should be a way for CDT to get rid of this bundle. Adding it to the update site would allow this without platform explicitly referencing it (yet).

Since we migrated it from CDT, there should be a way for CDT to get rid
of this bundle. Adding it to the update site would allow this without
platform explicitly referencing it (yet).
@laeubi
Copy link
Contributor Author

laeubi commented May 6, 2025

/request-license-review

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2025

/request-license-review

⚠️ Failed to request review of not vetted licenses.

Workflow run (with attached summary files):
https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/actions/runs/14859071374

@laeubi laeubi requested a review from merks May 6, 2025 12:21
@laeubi
Copy link
Contributor Author

laeubi commented May 6, 2025

The license check likley fails because we need an ibuild to update the branch pointers?!

As Jenkins succeed I think it can be merged.

@laeubi laeubi merged commit 0c936fd into eclipse-platform:master May 6, 2025
5 of 6 checks passed
@mickaelistria
Copy link
Contributor

Shouldn't it be added to some features/products as well?

@laeubi
Copy link
Contributor Author

laeubi commented May 7, 2025

@mickaelistria this will be automatically pulled by features/products once there is a reference so there is usually no need to explicitly include it.

@merks
Copy link
Contributor

merks commented May 7, 2025

Moreover, CDT currently has its own version that is included in a feature so, given this bundle is a singleton, so we need to be careful during the transition period that there isn't more than one feature including it because if those includes are of different versions, the two feature could not both be installed.

FYI @jonahgraham

@mickaelistria
Copy link
Contributor

this will be automatically pulled by features/products once there is a reference so there is usually no need to explicitly include it.

What is the dependency chain that includes it eg in the Eclipse SDK product right now?

@iloveeclipse
Copy link
Member

What is the dependency chain that includes it eg in the Eclipse SDK product right now?

As far as I can see latest nightly SDK doesn't include org.eclipse.tm.terminal.control.

@merks
Copy link
Contributor

merks commented May 7, 2025

Nothing includes it yet. So indeed, it's not in the product, yet either. That's why it's added to the category.xml directly, like is the case for other bundles mentioned directly in the category.xml, e.g., org.eclipse.equinox.slf4j so that we can make it available for consumption by CDT.

@laeubi
Copy link
Contributor Author

laeubi commented May 7, 2025

If someone is interested in the current POC it can be found here:

I hope to finish this for this release but maybe it is only used in the next release (2025-09) depending on how it works out as we need some coordination with CDT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants