-
Notifications
You must be signed in to change notification settings - Fork 89
Add CDT core native API bundle for compilation #3046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CDT core native API bundle for compilation #3046
Conversation
9f08c48 to
f921656
Compare
Now changed it to RC2 (what is what CDT currently contributes to simrel at the moment). |
f921656 to
d6120d5
Compare
|
Adjusted with final CDT release. |
d6120d5 to
851bae9
Compare
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
|
I guess this is first step before moving it to platform so CDT doesn't have to become a -1 project ? @jonahgraham Are you fine with releasing CDT 1 week before each Platform M/RC ? |
|
As long as we do not add new API (or more formally use that new API at platform), one won't need to update this in any way, this is more like Junit or any other dependecy, we use it and might update it when a new version become available, but it is not mandatory to update. Only for EPPs they might include latest CDT Terminal as its already the case. |
|
The problem is the other way around what if CDT changes the bundle after RC2 release ? |
|
That's theoretically possible, but if you look at the history of both APIs we use (pty + spawner) these have not changed for years (beside some bugfixes/enhancements) except the additional method I added recently for the platform use-case, so I'm quite confident @jonahgraham might inform us in-time and not completely change everything after RC2 :-) |
|
For any given 3rd party bundle x, the Platform doesn't include them in any feature and the dependencies (in bundles) specify a range, so it's always possible that some installation will contain a newer version of x than the one the Platform tested against. This might even happen for bundles pulled directly from Maven because a newer one might be available after the Platform's RC2 but before the rest of the train's RC2. In SimRel, generally the highest version permitted by all the dependency ranges is what will be aggregated. |
|
I agree with what @laeubi says - these things haven't changed in a long time. And I am happy to accommodate @akurtakov request as follows: If there are any changes that may affect Platforms consumption of these bundles then CDT will publish as a -1 for that change. xref new releasing documentation for CDT in eclipse-cdt/cdt#1190 |
|
One thing to note though is that when the platform shuts down after the final RC2 build, the target platform contains permanent released update sites, including for ecf, emf, and orbit, so that the branch can be built in the future. I don’t that you’re committing to producing the cdt release before the platform. Of course I don’t think it’s a big deal to commit the final cdt repo to the tp in the release and master branches when it’s available given only this one bundle is consumed from it and given we don’t plan to change it during the rc phase, but it is an additional step we should keep in mind and handle accordingly. |
|
It looks like there's no terminal native fragment for Linux Is there a plan to add this |
|
I was wondering about the fragments but didn’t find them when I looked. What is the id of such a fragment? If such a thing is needed for riscv64, it would be good to contribute to CDT whatever is needed. |
|
It should be like the following in its manifest (i.e. similar to the existing Linux x86_64 native fragment): Perhaps I should whip up a PR for such new terminal native fragment for |
|
@chirontt as mentioned by @merks contributions in this area has to go to CDT for the moment. In general if the usual Terminal View in the EPP works it should work here as well. Beside that there are two ways:
|
|
I now added a short introduction here: https://github.com/eclipse-platform/www.eclipse.org-eclipse/blob/master/news/4.37/platform.md |
Yes please. See eclipse-cdt/cdt#980 |
This is required for
currently it contains the cdt-main, but probably should reference the M2 repo (where relevant API was added) or a future CDT release.
Even though the bundle is named cdt it actually depends on nothing than JNA, therefore it can be used without really depend on CDT releases like any other API bundle (we just can't depend on new API if such would be ever added).
In a product one then would need to include the terminal feature (that includes the API and native fragments) to actually use the terminal console feature of platform.
FYI @merks @jonahgraham @akurtakov @stbischof