Simplify publishToMaven.jenkinsfile #3047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
merks
commented
May 16, 2025
merks
commented
- Install the latest CBI aggregator product directly from download.
- Update outdated comments.
- Don't check for .class files in jars because the CBI aggregator does that checking.
Contributor
Author
|
FYI, I did a replay with this version with just the final mvnd calls echoed instead of actually performing: https://ci.eclipse.org/releng/view/Publish%20to%20Maven/job/Releng/job/PublishToMaven/133/ |
HannesWell
approved these changes
May 16, 2025
Member
HannesWell
left a comment
HannesWell
left a comment
There was a problem hiding this comment.
Thank you for this update.
It looks good, I just have two minor points.
- Install the latest CBI aggregator product directly from download. - Update outdated comments. - Don't check for .class files in jars because the CBI aggregator does that checking.
merks
force-pushed
the
pr-maven-publish-simplify
branch
from
6dfc37b to
b99a4f5
Compare
Contributor
Author
|
Thank you for the good suggestions! |
Contributor
Author
|
I ran the maven build with this and it works nicely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.