Eliminate all source feature dependencies from org.eclipse.sdk

[merks]

No description provided.

[merks]

With the modern target platform support (tell PDE to include sources in the TP) and with modern Tycho builds (tell Tycho to installer source bundles into the product) source features are effectively useless. Better to remove them and lighten the load.

FYI @akurtakov @iloveeclipse

[iloveeclipse]

Ed, I'm not fully understand the implication of your proposal.
Does it mean, SDK will be built without sources?

[merks]

Ed, I'm not fully understand the implication of your proposal. Does it mean, SDK will be built without sources?

I'm glad you ask. 😁 I would have been disappointed if you did not express the desire to understand this fully!

See below. When you added the three new JDT features, you didn't add the corresponding *.source for them. But in the SDK product, you see that the source bundle is installed.

So as I understand it @laeubi has made Tycho support installing all corresponding source bundles even when there is no source feature specified to do that. This is why we've been able to move away from including 3ird party bundles from features.

So the only things that disappear are the .source features themselves:

And I will strongly assert that these things are almost completely useless. Because who would want to install such a feature in product. Who would want to add a dependency to such a feature anywhere? No one...

[iloveeclipse]

Thanks Ed for explanation. With that, assuming all the source bundles will be still there in SDK build, I have no objections.

[merks]

Also related:

eclipse-pde/eclipse.pde#1806

[HannesWell]

Thanks Ed for this change, it seems to be a follow-up on #2777 (comment) and will also enabled further clean-up of the SDK target.

I want to add, that in a target-file one can also specify includeSource="true" for IU-locations to include sources automatically, if they are available.

Furthermore PDE is about to get a new marker that tools like Tycho can use to add all sources in a feature automatically:

• Add support to add sources in the Feature Editor eclipse-pde/eclipse.pde#1613

And I will strongly assert that these things are almost completely useless. Because who would want to install such a feature in product. Who would want to add a dependency to such a feature anywhere? No one...

Agree. If we don't use the source-features at all, we could also stop generating them in the build. On the other hand some might have referenced them explicitly and might be worried. They could just remove these references, but it's also not much work for us to provide source features.