Comparator errors in I20250715-1800

[srikanth-sankaran]

Comparator differences from current build
/home/jenkins/agent/workspace/Builds/I-build-4.37/cje-production/siteDir/eclipse/downloads/drops4/I20250715-1800
compared to reference repo at
https://download.eclipse.org/eclipse/updates/4.37-I-builds/

1. eclipse.jdt.ui/org.eclipse.jdt.ui/pom.xml
   no-classifier: different
   org/eclipse/jdt/ui/actions/OrganizeImportsAction.class: different
   The main artifact has been replaced with the baseline version.
   The following attached artifacts have been replaced with the baseline version: [sources]

This is originating from eclipse-jdt/eclipse.jdt.core#4197 - the difference between baseline and build is that in the build version we seem to generate an extra access method:

 // access flags 0x1008
  static synthetic access$0(Lorg/eclipse/jdt/ui/actions/OrganizeImportsAction;I[Lorg/eclipse/jdt/core/ISourceRange;Lorg/eclipse/jdt/internal/ui/javaeditor/JavaEditor;)V
    ALOAD 0
    ILOAD 1
    ALOAD 2
    ALOAD 3
    INVOKESPECIAL org/eclipse/jdt/ui/actions/OrganizeImportsAction.doListSelectionChanged (I[Lorg/eclipse/jdt/core/ISourceRange;Lorg/eclipse/jdt/internal/ui/javaeditor/JavaEditor;)V
    RETURN
    MAXSTACK = 4
    MAXLOCALS = 4

I am investigating why this change has come about - This is not a correctness issue - but a sub-optimal code issue.

[srikanth-sankaran]

This is not a correctness issue - but a sub-optimal code issue.

Test results look fine.

[srikanth-sankaran]

Found the issue : eclipse-jdt/eclipse.jdt.core#4204 - Fix is simple and straightforward and a PR will follow shortly.

[srikanth-sankaran]

This is not a correctness issue - but a sub-optimal code issue.

The access method is emitted. But invocation of the private method still happens directly. So suboptimality is limited to space (a short piece of dead method emitted into class file), not time.

[srikanth-sankaran]

PR under test here: eclipse-jdt/eclipse.jdt.core#4206

[srikanth-sankaran]

PR under test here: eclipse-jdt/eclipse.jdt.core#4206

Integrated into master - I will wait that tomorrow's I-build is fine and close this

[MohananRahul]

Integrated into master - I will wait that tomorrow's I-build is fine and close this

Started new Ibuild https://ci.eclipse.org/releng/job/Builds/job/I-build-4.37/68/

[srikanth-sankaran]

Integrated into master - I will wait that tomorrow's I-build is fine and close this

Started new Ibuild https://ci.eclipse.org/releng/job/Builds/job/I-build-4.37/68/

Thanks @MohananRahul - appreciated :)

[iloveeclipse]

Fixed, new (OK) build is there: https://download.eclipse.org/eclipse/downloads/drops4/I20250716-0800/