[Build] Restore compressed content.xml for platform repository #3187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HannesWell
force-pushed
the
restore-content.jar
branch
from
0852cd8 to
0000663
Compare
HannesWell
commented
Jul 16, 2025
Comment on lines
+22
to
+26
| <iu> | ||
| <query> | ||
| <expression type="match">id == 'org.eclipse.equinox.executable'</expression> | ||
| </query> | ||
| </iu> |
Member
Author
There was a problem hiding this comment.
This is an alternative approach to explicitly include the org.eclipse.equinox.executable generated by Equinox.
I copied this approach (and simplified it) from
https://github.com/eclipse-m2e/m2e-core/blob/f64b9290f2e3dd0c7b6f14a185edc36286590933/org.eclipse.m2e.repository/category.xml#L21-L30
Contributor
There was a problem hiding this comment.
That's certainly MUCH simpler!
Include the additional IU 'org.eclipse.equinox.executable' directly in the platform P2-repository via the defining 'category.xml'. This avoids the post-processing of the raw 'content.xml' file using an XSL transformation and consequently ensures the 'content.xml' is only provided in compressed form as 'content.jar' and 'content.xml.xz'. Due to the previous post-processing the content.xml was only provided uncompressed, which increases the load on the download-server, slows down metadata downloads and also complicates the RelEng process. Fixes eclipse-platform#1912
HannesWell
force-pushed
the
restore-content.jar
branch
from
0000663 to
efacec9
Compare
HannesWell
changed the title
Member
Author
|
The build is successful and the resulting So everything looks good and this is ready for submission. @MohananRahul, with this applied, the (manually defined) Jenkins job to recreate the compressed artifacts is obsolete and I'll delete it: As far as I can tell, it was never documented that this is to be run for milestone, RC and GA builds, so nothing has to be cleaned up in this regard. |
Contributor
|
That’s really great. 👍 |
HannesWell
force-pushed
the
restore-content.jar
branch
from
60ed872 to
efacec9
Compare
HannesWell
added a commit
to HannesWell/eclipse.platform.releng.aggregator
that referenced
this pull request
Jul 18, 2025
Include the additional IU 'org.eclipse.equinox.executable' directly in the platform P2-repository via the defining 'category.xml'. This avoids the post-processing of the raw 'content.xml' file using an XSL transformation and consequently ensures the 'content.xml' is only provided in compressed form as 'content.jar' and 'content.xml.xz'. Due to the previous post-processing the content.xml was only provided uncompressed, which increases the load on the download-server, slows down metadata downloads and also complicates the RelEng process. Fixes eclipse-platform#1912 This was originally introduced via - eclipse-platform#3187 and reverted due to a regression in I-builds via - eclipse-platform#3189 As the cause of that regression is fixed, the change is introduced again unchanged and This reverts commit d4d0542.
HannesWell
added a commit
to HannesWell/eclipse.platform.releng.aggregator
that referenced
this pull request
Jul 19, 2025
Include the additional IU 'org.eclipse.equinox.executable' directly in the platform P2-repository via the defining 'category.xml'. This avoids the post-processing of the raw 'content.xml' file using an XSL transformation and consequently ensures the 'content.xml' is only provided in compressed form as 'content.jar' and 'content.xml.xz'. Due to the previous post-processing the content.xml was only provided uncompressed, which increases the load on the download-server, slows down metadata downloads and also complicates the RelEng process. Fixes eclipse-platform#1912 This was originally introduced via - eclipse-platform#3187 and reverted due to a regression in I-builds via - eclipse-platform#3189 As the cause of that regression is fixed, the change is introduced again unchanged and This reverts commit d4d0542.
HannesWell
added a commit
that referenced
this pull request
Jul 19, 2025
Include the additional IU 'org.eclipse.equinox.executable' directly in the platform P2-repository via the defining 'category.xml'. This avoids the post-processing of the raw 'content.xml' file using an XSL transformation and consequently ensures the 'content.xml' is only provided in compressed form as 'content.jar' and 'content.xml.xz'. Due to the previous post-processing the content.xml was only provided uncompressed, which increases the load on the download-server, slows down metadata downloads and also complicates the RelEng process. Fixes #1912 This was originally introduced via - #3187 and reverted due to a regression in I-builds via - #3189 As the cause of that regression is fixed, the change is introduced again unchanged and This reverts commit d4d0542.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include the additional IU
org.eclipse.equinox.executabledirectly in the platform P2-repository via the definingcategory.xml. This avoids the post-processing of the rawcontent.xmlfile using an XSL transformation and consequently ensures thecontent.xmlis only provided in compressed form as 'content.jar' andcontent.xml.xz.Due to the previous post-processing the
content.xmlwas only provided uncompressed, which increases the load on the download-server, slows down metadata downloads and also complicates the RelEng process.Fixes #1912