-
Notifications
You must be signed in to change notification settings - Fork 89
Enhance promotion job names and parameters #3200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance promotion job names and parameters #3200
Conversation
94ed411 to
4bd74aa
Compare
4bd74aa to
7640987
Compare
- Remove those parameters that can be derived from others. - Move creation of 'mailtemplate.txt' file to Jenkins pipeline. - Drop creation of unused 'checklist.txt' file. - Drop consideration of 'M'-DROP_IDs, which are not produced anymore.
7640987 to
3e9b69e
Compare
|
My testing was successful, so lets see if it also works in the real world. |
|
@MohananRahul the new jobs are created at:
Please use them when you do the M2 promotion tomorrow (your today). I have not yet deleted the old jobs to keep them as a reference until the M2 promotion is done. |
|
And in the future I plan to move more tasks into the two new jobs like sending the mails when the publication is completed or triggering the maven-deployment (only to Central staging, the final release still has to be done by hand) when a release is promoted. |
M2 Successfully promoted https://download.eclipse.org/eclipse/downloads/drops4/S-4.37M2-202507241800/ |
Great, thanks for reporting back. |
|
@HannesWell, just to confirm - for the final release, can we use the DROP_ID as S-4.3XRC2-X-X for the promotion? |
Yes, that's possible and I would even recommend to use the RC2(x) ID as we then don't have to disable any clean job to ensure the source I-build is present. In fact you can promote all of I-builds, milestones or RCs to GA release (i.e. an empty eclipse.platform.releng.aggregator/JenkinsJobs/Releng/promoteBuild.jenkinsfile Lines 31 to 40 in 8b27105
|
This PR enhances the Jenkins jobs in https://ci.eclipse.org/releng/job/Releng/ for the build promotion and publication first by renaming
Releng/renameAndPromotetoReleng/promoteBuildReleng/makeVisibletoReleng/publishPromotedBuildwhich I think is a bit more suitable.
@MohananRahul and maybe @merks or anybody else: What do you think?
And second by reducing the number of parameters of the (previous
renameAndPromote)promoteBuildjob as they are actually redundant and can be deirved from other values or data.This still needs some testing but I would like to have this ready for M2 so that the new jobs can be used for that promotion, @MohananRahul. Or is M2 totally silent and no promotion to Milestone happen?