Bump org.apache.maven.plugins:maven-javadoc-plugin from 3.11.2 to 3.11.3

[dependabot]

Bumps org.apache.maven.plugins:maven-javadoc-plugin from 3.11.2 to 3.11.3.

Release notes

Sourced from org.apache.maven.plugins:maven-javadoc-plugin's releases.

3.11.3

🚨 Removed

• Remove workaround for long patched CVE in javadoc (#388) @​elharo

🚀 New features and improvements

• Issue #369 Support --no-fonts option per default for jdk 23+ (#375) @​olamy

🐛 Bug Fixes

• Make the legacyMode consistent (Filter out all of the module-info.java files in legacy mode, do not use --source-path in legacy mode) (#1217) @​fridrich
• [MJAVADOC-826] - Don't try to modify project source roots (#358) @​oehme

📝 Documentation updates

• Correct javadoc-no-fork description on index-page (#368) @​Bukama
• [MNGSITE-529] - Rename "Goals" to "Plugin Documentation" (#360) @​Bukama
• (doc) Close links tag in links parameter javadoc example (#355) @​sixcorners

👻 Maintenance

• Be consistent about data encoding when copying files (#1215) @​fridrich
• Clean up JavadocUtilTest (#1210) @​elharo
• Use Java 7 relativization instead of hand-rolled code (#385) @​elharo
• Rephrase source code fix interactive messages for clarity (#390) @​elharo
• Reduce non-debug logging (#389) @​elharo
• Delete duplicate @​throws clause (#384) @​elharo
• Use Java 7 relativization instead of our hand-rolled code (#381) @​elharo
• Clean up comments and argument names (#386) @​elharo
• Remove workaround for long patched CVE in javadoc (#388) @​elharo
• Issue #378 Cleanup of code related to old non supported Java version (#382) @​olamy
• Cure deprecation warning (#383) @​elharo
• [MJAVADOC-773] - deprecate toRelative (#379) @​elharo
• Issue #373 Fix JDK 23 build (#374) @​olamy
• Fix aggregate Javadoc typo (#371) @​JackPGreen
• Enable GH issues (#365) @​Bukama
• [MJAVADOC-825] - Prefer NullPointerExceptions for null arguments (#350) @​elharo

📦 Dependency updates

• Bump commons-io:commons-io from 2.19.0 to 2.20.0 (#1221) @dependabot[bot]
• Bump org.apache.commons:commons-text from 1.13.1 to 1.14.0 (#1222) @dependabot[bot]
• Bump org.apache.commons:commons-lang3 from 3.6 to 3.18.0 in /src/it/projects/MJAVADOC-787 (#1227) @dependabot[bot]
• Maven Archiver 3.6.4 (#1226) @​olamy
• Bump org.apache.commons:commons-lang3 from 3.6 to 3.18.0 in /src/it/projects/MJAVADOC-575_source8-module-info (#1224) @dependabot[bot]
• Bump org.assertj:assertj-core from 3.27.3 to 3.27.4 (#1223) @dependabot[bot]
• Bump org.apache.commons:commons-lang3 from 3.6 to 3.18.0 in /src/it/projects/MJAVADOC-506_excl-module-info (#1218) @dependabot[bot]
• Bump org.codehaus.plexus:plexus-java from 1.3.0 to 1.5.0 (#363) @dependabot[bot]

... (truncated)

Commits

• 8357bc2 [maven-release-plugin] prepare release maven-javadoc-plugin-3.11.3
• ab6e97e Bump commons-io:commons-io from 2.19.0 to 2.20.0
• 83788c1 Bump org.apache.commons:commons-text from 1.13.1 to 1.14.0
• 99ee1fc Bump org.apache.commons:commons-lang3 in /src/it/projects/MJAVADOC-787
• 18bfeb8 Maven Archiver 3.6.4 (#1226)
• 63618bb Bump org.apache.commons:commons-lang3 (#1224)
• 81afff9 Bump org.assertj:assertj-core from 3.27.3 to 3.27.4 (#1223)
• 8bcdebf Add Apache 2.0 LICENSE file (#1220)
• 2299072 Make the legacyMode consistent and actually useful (#1217)
• 33c9f01 Be consistent about data encoding when copying files (#1215)
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[HannesWell]

@akurtakov is this ready?

[akurtakov]

TBH, I am not sure. Javadoc in non legacy mode(modules!) used to cause problems . If verification succeeds we might not have a choice but to merge it and see whether bundles javadoc fail after that.

[HannesWell]

The verification build succeeded, then let's see if this also works in general.

[akurtakov]

So it broke the per module javadoc generation eclipse-equinox/p2#940 . Should we revert or give it some time for someone to investigate?

[iloveeclipse]

So it broke the per module javadoc generation eclipse-equinox/p2#940 . Should we revert or give it some time for someone to investigate?

Also PDE build seems to be broken on Jenkins:

https://ci.eclipse.org/pde/job/eclipse.pde/job/PR-1965/2/pipeline-overview/

18:31:38  [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.11.3:jar (attach-javadocs) on project org.eclipse.pde.build: MavenReportException: Error while generating Javadoc: 
18:31:38  [ERROR] Exit code: 2
18:31:38  [ERROR] error: No source files for package org.eclipse.pde.build
18:31:38  [ERROR] 1 error
18:31:38  [ERROR] Command line was: /opt/tools/java/temurin/jdk-21/jdk-21.0.8+9/bin/javadoc -J-Duser.language= -J-Duser.country= @options @packages
18:31:38  [ERROR] 
18:31:38  [ERROR] Refer to the generated Javadoc files in '/home/jenkins/agent/workspace/eclipse.pde_PR-1965/build/org.eclipse.pde.build/target/reports/apidocs' dir.
18:31:38  [ERROR] -> [Help 1]
18:31:38  org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.11.3:jar (attach-javadocs) on project org.eclipse.pde.build: MavenReportException: Error while generating Javadoc: 
18:31:38  Exit code: 2
18:31:38  error: No source files for package org.eclipse.pde.build
18:31:38  1 error
18:31:38  Command line was: /opt/tools/java/temurin/jdk-21/jdk-21.0.8+9/bin/javadoc -J-Duser.language= -J-Duser.country= @options @packages
18:31:38  
18:31:38  Refer to the generated Javadoc files in '/home/jenkins/agent/workspace/eclipse.pde_PR-1965/build/org.eclipse.pde.build/target/reports/apidocs' dir.

[iloveeclipse]

Should we revert or give it some time for someone to investigate?

With at least two projects affected I would revert.

[laeubi]

The verification build succeeded, then let's see if this also works in general.

Please note that javadoc needs to be explicitly enabled with -Pjavadoc profile, but such changes are best tested with a local build first, the javadoc generation is quite brittle and the plugin often buggy, please report issues here:

• https://github.com/apache/maven-javadoc-plugin/issues

[laeubi]

I looked into this now and it could be that javadoc-plugin changed or it depends on java version (making a warning now an error).

[laeubi]

@akurtakov is there any reason the <legacyMode> option was removed?

From the docu

Run the javadoc tool in pre-Java 9 (non-modular) style even if the java version is post java 9. This allows non-JPMS projects that have moved to newer Java versions to create javadocs without having to use JPMS modules.

I would assume we are not planning to move to JPMS module system at platform? If I add the option back the build is working again.

What also would work is using

pom.model.property.javadoc.excludePackageNames = org.eclipse.equinox.internal.p2.jarprocessor.ant

in the build.properties of the projects now failing to exclude package names that are not part of the result (e.g. because embedded as inner jars) but this gives me additional warning

[INFO] --- javadoc:3.11.3:jar (attach-javadocs) @ org.eclipse.equinox.p2.jarprocessor ---
[WARNING] Javadoc 1.4+ doesn't support the -1.1 switch anymore. Ignore this option.
[WARNING] Javadoc Warnings
[WARNING] warning: The code being documented uses modules but the packages defined in https://docs.osgi.org/javadoc/osgi.core/8.0.0/ are in the unnamed module.
[WARNING] 1 warning
[INFO] Building jar: /opt/eclipse/platform-sdk/git/p2/bundles/org.eclipse.equinox.p2.jarprocessor/target/org.eclipse.equinox.p2.jarprocessor-1.3.600-SNAPSHOT-javadoc.jar