An error occurred while pre-processing help XHTML document "/org.eclipse.platform.doc.isv/guide/p2_repositorytasks.htm" for search indexing

[ptziegler]

Let's make sure issue is not already fixed in latest builds first.

• I verified I can reproduce this issue against latest Integration Build of Eclipse SDK

Long story short: The p2_repositorytasks.htm is an XHTML document, not an HTML document. While </br> is forbidden in HTML, it is required in XHTML.

This has been caused by c2e9e53.

Here is some relevant log output

!MESSAGE An error occurred while pre-processing help XHTML document "/org.eclipse.platform.doc.isv/guide/p2_repositorytasks.htm" for search indexing
!STACK 0
org.xml.sax.SAXParseException; lineNumber: 1016; columnNumber: 17; The element type "br" must be terminated by the matching end-tag "</br>".
	at java.xml/com.sun.org.apache.xerces.internal.parsers.DOMParser.parse(DOMParser.java:262)
	at java.xml/com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderImpl.parse(DocumentBuilderImpl.java:342)
	at org.eclipse.help.internal.entityresolver.LocalEntityResolver.parse(LocalEntityResolver.java:88)
	at org.eclipse.help.internal.dynamic.DocumentReader.read(DocumentReader.java:56)
	at org.eclipse.help.internal.dynamic.XMLProcessor.process(XMLProcessor.java:52)
	at org.eclipse.help.internal.xhtml.DynamicXHTMLProcessor.process(DynamicXHTMLProcessor.java:65)
	at org.eclipse.help.internal.search.XHTMLSearchParticipant.preprocess(XHTMLSearchParticipant.java:101)
	at org.eclipse.help.search.SearchParticipantXML.addDocument(SearchParticipantXML.java:300)
	at org.eclipse.help.internal.search.HTMLSearchParticipant.addDocument(HTMLSearchParticipant.java:57)
	at org.eclipse.help.internal.search.SearchIndex.addDocument(SearchIndex.java:294)
	at org.eclipse.help.internal.search.IndexingOperation.addDocuments(IndexingOperation.java:249)
	at org.eclipse.help.internal.search.IndexingOperation.addNewDocuments(IndexingOperation.java:160)
	at org.eclipse.help.internal.search.IndexingOperation.execute(IndexingOperation.java:109)
	at org.eclipse.help.internal.search.LocalSearchManager.updateIndex(LocalSearchManager.java:652)
	at org.eclipse.help.internal.search.LocalSearchManager.ensureIndexUpdated(LocalSearchManager.java:626)
	at org.eclipse.help.internal.search.federated.IndexerJob.run(IndexerJob.java:35)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)

Tested under this environment:

• OS & version: Kubuntu 24.04
• Eclipse IDE/Platform version (as shown in Help > About): I20250820-1800

Community

• I understand reporting an issue to this OSS project does not mandate anyone to fix it. Other contributors may consider the issue, or not, at their own convenience. The most efficient way to get it fixed is that I fix it myself and contribute it back as a good quality patch to the project.

[akurtakov]

I agree with the fix for RC2.
In general though we would better:

• convert everything to html 5 for better compatibility with both browsers and developer habbits, having one file require br/ and the other forbidding it is a recipe for failure
• setup some GHA to validate html files