I20251107-1800 - BUILD FAILED

[iloveeclipse]

https://ci.eclipse.org/releng/job/Builds/job/I-build-4.38/108/console

Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:5.0.1-SNAPSHOT:compile (default-compile) on project org.eclipse.jface: Compilation failure: Compilation failure: 
00:10:20.797  [ERROR] /home/jenkins/agent/workspace/Builds/I-build-4.38/cje-production/gitCache/eclipse.platform.releng.aggregator/eclipse.platform.ui/bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/AnimatorFactory.java:[23] 
00:10:20.797  [ERROR] 	* {@link org.eclipse.jface.util.Policy#setAnimatorFactory(AnimatorFactory)}
00:10:20.797  [ERROR] 	                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
00:10:20.798  [ERROR] Javadoc: The method setAnimatorFactory(AnimatorFactory) from the type Policy is deprecated

[iloveeclipse]

Probably regression from eclipse-jdt/eclipse.jdt.core#4595

[stephan-herrmann]

• It is a necessary correction in the compiler that terminal deprecation must be flagged even if the enclosing code region is deprecated itself
• I'm surprised the warning doesn't mention forRemoval
• I am not 100% sure how the general rule applies to references within javadoc.

[stephan-herrmann]

Regarding deprecation warnings within javadoc:

• I'm not aware of any specification (incl JEP 277) that regulates such warnings within javadoc
• ecj has separate options for this, see in particular org.eclipse.jdt.core.JavaCore.COMPILER_PB_INVALID_JAVADOC_TAGS__DEPRECATED_REF
  • configuring this to ERROR is quite a bold statement, I'm not quite sure this is a useful choice.
• ecj has a tweak for deprecation warnings within javadoc that suppresses some warnings if the javadoc appears in a non-public context, which is not the case here.

Pragmatic suggestion: modify that javadoc to use plain text instead of a validated {@link ...}

[HannesWell]

Pragmatic suggestion: modify that javadoc to use plain text instead of a validated {@link ...}

Yes, that should work. First I tried the 'clean' solution to suppress the warning in

• Avoid removal warning in AnimatorFactory due to java-doc reference eclipse.platform.ui#3521

But that seems to not work. I'll go with pragmatic approach now to fix the build.
We can then later still see if it can be done better. OTOH, that class is to be gone in some time anyways.

[laeubi]

I started a new ibuild now!

[laeubi]

Build was successful now!