Skip to content

[Build] Remove definition PLUGIN_PATH system-property for I-build tests #2989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2025
Merged

[Build] Remove definition PLUGIN_PATH system-property for I-build tests #2989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9228ed6
[Build] Remove definition PLUGIN_PATH system-property for I-build tests
HannesWell Apr 17, 2025
0c86e15
Version bump(s) for 4.36 stream
eclipse-platform-bot Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions eclipse.platform.releng.tychoeclipsebuilder/eclipse-junit-tests/src/main/scripts/library.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,6 @@

test-output - overrides default output file produced from test run. [May not currently override default?]

plugin-path - path to root of plug-in

useEclipseExe - property setting forces test to launch via eclipse executable. [Not fully supported. See bug 387638.]

junit-report-output - output directory for junit reports produced for specified classname.
Expand Down Expand Up @@ -150,9 +148,6 @@
<property
name="extraVMargs"
value="" />
<property
name="plugin-path"
value="" />

<property
name="timeout"
Expand Down Expand Up @@ -271,9 +266,6 @@
<arg value="-junitReportOutput" />
<arg path="${junit-report-output}" />
<jvmarg line="${frameworkvmargs} ${loglocation} ${vmargs} ${extraVMargs} ${frameworkperfargs}" />
<sysproperty
key="PLUGIN_PATH"
value="${plugin-path}" />
<env
key="ECLIPSE_I_BUILD_TEST"
value="true"/>
Expand Down Expand Up @@ -339,7 +331,7 @@
<arg line="-nosplash" />
<arg line="--launcher.suppressErrors" />
<arg line="${consolelog}" />
<arg line="-vmargs ${frameworkvmargs} ${loglocation} ${vmargs} ${extraVMargs} -DPLUGIN_PATH=${plugin-path}" />
<arg line="-vmargs ${frameworkvmargs} ${loglocation} ${vmargs} ${extraVMargs}" />
</exec>
<antcall target="collect-results" />
</target>
Expand Down
2 changes: 1 addition & 1 deletion eclipse.platform.releng/bundles/org.eclipse.releng.tests/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %Plugin.name
Bundle-SymbolicName: org.eclipse.releng.tests;singleton:=true
Bundle-Version: 3.6.600.qualifier
Bundle-Version: 3.6.700.qualifier
Eclipse-BundleShape: dir
Bundle-Vendor: %Plugin.providerName
Bundle-Localization: plugin
Expand Down
2 changes: 1 addition & 1 deletion eclipse.platform.releng/bundles/org.eclipse.releng.tests/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
</parent>
<groupId>org.eclipse.platform</groupId>
<artifactId>org.eclipse.releng.tests</artifactId>
<version>3.6.600-SNAPSHOT</version>
<version>3.6.700-SNAPSHOT</version>
<packaging>eclipse-test-plugin</packaging>
<properties>
<testSuite>${project.artifactId}</testSuite>
Expand Down
4 changes: 0 additions & 4 deletions eclipse.platform.releng/bundles/org.eclipse.releng.tests/test.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,10 +226,6 @@
<property
name="classname"
value="org.eclipse.releng.tests.BuildTests" />
<property
name="plugin-path"
value="${eclipse-home}/plugins/${org.eclipse.releng.tests}" />

<property
name="vmargs"
value="-DdownloadHost=${downloadHost} -DbuildId=${buildId}" />
Expand Down