Remove remaining explicit source-features from eclipse-sdk target #3106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Source features are not needed anymore at all (the TP is configured to automatically include sources), now that the eclipse.sdk feature does not include source features explicitly anymore: - eclipse-platform#3100 Follow-up on - eclipse-platform#2777
Contributor
|
Please be careful. I thin, it's best to do this is stages starting with ECF. I'm holding off on this until the I-builds are stable again: Then I can fix the target platform for that. The category.xml needs attention:
And for ECF's features, the Equinox SDK product:
|
They are automatically included by Tycho in the build.
Member
Author
No rush, this is not urgent. I'll wait until your work is done.
I think we can actually remove all sources from that: (also included this change here to verify that it fixes the test-failure). |
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source features are not needed anymore at all (the TP is configured to automatically include sources), now that the eclipse.sdk feature does not include source features explicitly anymore:
Follow-up on