[RelEng] Make read of releaseName more robust in publication pipeline #3310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't launch Maven to output the interpolated 'releaseName' property, but instead read the 'releaseYear' and 'releaseMonth' properties from the raw (eclipse-platform-parent/pom.xml) file. This avoids problems if at the time of the release (candidate) build a snapshot version was used, e.g. of Tycho, that's not available anymore at the time of the publication (because e.g. that Tycho version was released in the meantime).
Member
Author
|
The verification build doesn't test this, thus I'm submitting this immediately to fix this blocker (i.e. the use of Tycho 5.0.0-SNAPSHOT at the time of the release build) for tomorrows release publication. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't launch Maven to output the interpolated
releaseNameproperty, but instead read thereleaseYearandreleaseMonthproperties from the raw (eclipse-platform-parent/pom.xml) file.This avoids problems if at the time of the release (candidate) build a snapshot version was used, e.g. of Tycho, that's not available anymore at the time of the publication (because e.g. that Tycho version was released in the meantime).