Create Font handles on demand

Creating a new static method to retrieve font handle. Handles will no
longer be created during initialization. Also destroy condition is
changed since handle being 0 doesn't mean that it was destroyed anymore.

Author: ShahzaibIbrahim

bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Font.java

@@ -55,6 +55,16 @@ public final class Font extends Resource {
 	 */
 	int zoom;
 
+	/**
+	 * this field is used to mark destroyed fonts
+	 */
+	private boolean isDestroyed;
+
+	/**
+	 * this field is used to store fontData provided during initialization
+	 */
+	private final FontData fontData;
+
 	/**
 	 * Font height in points. As the conversion to pixel height involves rounding the fontHeight must
 	 * be cached.
@@ -66,12 +76,14 @@ public final class Font extends Resource {
  */
 Font(Device device) {
 	super(device);
+	this.fontData = null;
 	this.zoom = DPIUtil.getNativeDeviceZoom();
 	this.fontHeight = 0;
 }
 
 private Font(Device device, long handle, int zoom) {
 	super(device);
+	this.fontData = null;
 	this.handle = handle;
 	this.zoom = zoom;
 	this.fontHeight = device.computePoints(fetchLogFontData(), handle, zoom);
@@ -99,16 +111,18 @@ private Font(Device device, long handle, int zoom) {
  */
 public Font(Device device, FontData fd) {
 	super(device);
+	if (fd == null) SWT.error(SWT.ERROR_NULL_ARGUMENT);
 	this.zoom = DPIUtil.getNativeDeviceZoom();
-	init(fd);
+	this.fontData = new FontData(fd.toString());
 	this.fontHeight = fd.height;
 	init();
 }
 
 private Font(Device device, FontData fd, int zoom) {
 	super(device);
+	if (fd == null) SWT.error(SWT.ERROR_NULL_ARGUMENT);
 	this.zoom = zoom;
-	init(fd);
+	this.fontData = new FontData(fd.toString());
 	this.fontHeight = fd.height;
 	init();
 }
@@ -147,7 +161,7 @@ public Font(Device device, FontData[] fds) {
 	}
 	this.zoom = DPIUtil.getNativeDeviceZoom();
 	FontData fd = fds[0];
-	init(fds[0]);
+	this.fontData = new FontData(fd.toString());
 	this.fontHeight = fd.height;
 	init();
 }
@@ -180,7 +194,7 @@ public Font(Device device, String name, int height, int style) {
 	super(device);
 	if (name == null) SWT.error(SWT.ERROR_NULL_ARGUMENT);
 	this.zoom = DPIUtil.getNativeDeviceZoom();
-	init(new FontData (name, height, style));
+	this.fontData = new FontData (name, height, style);
 	this.fontHeight = height;
 	init();
 }
@@ -189,14 +203,15 @@ public Font(Device device, String name, int height, int style) {
 	super(device);
 	if (name == null) SWT.error(SWT.ERROR_NULL_ARGUMENT);
 	this.zoom = DPIUtil.getNativeDeviceZoom();
-	init(new FontData (name, height, style));
+	this.fontData =  new FontData (name, height, style);
 	this.fontHeight = height;
 	init();
 }
 @Override
 void destroy() {
 	OS.DeleteObject(handle);
 	handle = 0;
+	isDestroyed = true;
 }
 
 /**
@@ -214,7 +229,7 @@ public boolean equals(Object object) {
 	if (object == this) return true;
 	if (!(object instanceof Font)) return false;
 	Font font = (Font) object;
-	return device == font.device && handle == font.handle;
+	return device == font.device && win32_getHandle(this) == win32_getHandle(font);
 }
 
 /**
@@ -237,7 +252,7 @@ public FontData[] getFontData() {
 
 private LOGFONT fetchLogFontData() {
 	LOGFONT logFont = new LOGFONT ();
-	OS.GetObject(handle, LOGFONT.sizeof, logFont);
+	OS.GetObject(win32_getHandle(this), LOGFONT.sizeof, logFont);
 	return logFont;
 }
 
@@ -253,7 +268,7 @@ private LOGFONT fetchLogFontData() {
  */
 @Override
 public int hashCode () {
-	return (int)handle;
+	return (int) win32_getHandle(this);
 }
 
 void init (FontData fd) {
@@ -278,7 +293,7 @@ void init (FontData fd) {
  */
 @Override
 public boolean isDisposed() {
-	return handle == 0;
+	return isDestroyed;
 }
 
 /**
@@ -309,7 +324,7 @@ public String toString () {
  * @noreference This method is not intended to be referenced by clients.
  */
 public static long win32_getHandle (Font font) {
-	if(font.handle == 0) {
+	if(font.handle == 0 && font.fontData != null) {
 		font.init(font.fontData);
 	}
 	return font.handle;

bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/internal/SWTFontProvider.java

@@ -48,7 +48,7 @@ public static Font getSystemFont(Device device, int zoom) {
 	}
 
 	public static long getSystemFontHandle(Device device, int zoom) {
-		return getSystemFont(device, zoom).handle;
+		return Font.win32_getHandle(getSystemFont(device, zoom));
 	}
 
 	/**
@@ -67,14 +67,14 @@ public static Font getFont(Device device, FontData fontData, int zoom) {
 	}
 
 	public static long getFontHandle(Device device, FontData fontData, int zoom) {
-		return getFont(device, fontData, zoom).handle;
+		return Font.win32_getHandle(getFont(device, fontData, zoom));
 	}
 
 	public static long getFontHandle(Font font, int zoom) {
 		if (font == null) {
 			SWT.error(SWT.ERROR_NULL_ARGUMENT);
 		}
-		return getFont(font.getDevice(), font.getFontData()[0], zoom).handle;
+		return Font.win32_getHandle(getFont(font.getDevice(), font.getFontData()[0], zoom));
 	}
 
 	/**

bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/internal/ScalingSWTFontRegistry.java

@@ -44,7 +44,7 @@ private Font getScaledFont(int zoom) {
 
 		private Font createAndCacheFont(int zoom) {
 			Font newFont = createFont(zoom);
-			customFontHandlesKeyMap.put(newFont.handle, this);
+			customFontHandlesKeyMap.put(Font.win32_getHandle(newFont), this);
 			scaledFonts.put(zoom, newFont);
 			return newFont;
 		}

bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Control.java

@@ -3441,7 +3441,7 @@ public void setFont (Font font) {
 	long hFont = 0;
 	if (newFont != null) {
 		if (newFont.isDisposed()) error(SWT.ERROR_INVALID_ARGUMENT);
-		hFont = newFont.handle;
+		hFont = Font.win32_getHandle(newFont);
 	}
 	this.font = newFont;
 	if (hFont == 0) hFont = defaultFont ();