Skip to content

Commit 0ef6051

Browse files
jonahgrahamakurtakov
authored andcommitted
Add all missing tests to suite, mark abstract tests as such
AllWidgetTests was missing a bunch of tests, some of them seem not very consequential (simple listener tests such as for example [Test_org_eclipse_swt_custom_VerifyKeyListener](https://github.com/eclipse-platform/eclipse.platform.swt/blob/d5dc66178647fa40b14165a7b54bc3be8e013174/tests/org.eclipse.swt.tests/JUnit%20Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_custom_VerifyKeyListener.java) But other ones seem to test important functionality and are rather more substantial, such as [Test_org_eclipse_swt_widgets_TreeColumn](https://github.com/eclipse-platform/eclipse.platform.swt/blob/d5dc66178647fa40b14165a7b54bc3be8e013174/tests/org.eclipse.swt.tests/JUnit%20Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_widgets_TreeColumn.java) There are a few test classes which are super classes of other test classes and exist to match all the SWT classes. These have been marked as abstract so that it is obvious why they are not included. If you had try to run them they would have mostly failed. The secondary advantage of explicitly marking them abstract is that JDT won't run them as a test from within Eclipse IDE. There are three test classes that don't pass, I have added them to the list commented out for now, but if they are easy enough to resolve I will enable them too. Fixes #2542
1 parent f7223a8 commit 0ef6051

File tree

5 files changed

+14
-4
lines changed

5 files changed

+14
-4
lines changed

tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/AllWidgetTests.java

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,22 +23,31 @@
2323
@Suite
2424
@SelectClasses({ //
2525
// Sorted list of tests
26+
// Failing test: Test_org_eclipse_swt_custom_BidiSegmentListener.class, //
2627
Test_org_eclipse_swt_custom_BusyIndicator.class, //
2728
Test_org_eclipse_swt_custom_CCombo.class, //
2829
Test_org_eclipse_swt_custom_CLabel.class, //
2930
Test_org_eclipse_swt_custom_CTabFolder.class, //
3031
Test_org_eclipse_swt_custom_CTabItem.class, //
32+
Test_org_eclipse_swt_custom_ExtendedModifyListener.class, //
33+
Test_org_eclipse_swt_custom_LineBackgroundListener.class, //
34+
Test_org_eclipse_swt_custom_LineStyleListener.class, //
3135
Test_org_eclipse_swt_custom_StyleRange.class, //
3236
Test_org_eclipse_swt_custom_StyledText.class, //
37+
// Failing test: Test_org_eclipse_swt_custom_StyledTextContent.class, //
3338
Test_org_eclipse_swt_custom_StyledTextLineSpacingProvider.class, //
3439
Test_org_eclipse_swt_custom_StyledText_VariableLineHeight.class, //
3540
Test_org_eclipse_swt_custom_StyledText_multiCaretsSelections.class, //
41+
Test_org_eclipse_swt_custom_TextChangeListener.class, //
42+
Test_org_eclipse_swt_custom_VerifyKeyListener.class, //
3643
Test_org_eclipse_swt_widgets_Button.class, //
3744
Test_org_eclipse_swt_widgets_Canvas.class, //
3845
Test_org_eclipse_swt_widgets_Caret.class, //
3946
Test_org_eclipse_swt_widgets_ColorDialog.class, //
4047
Test_org_eclipse_swt_widgets_Combo.class, //
4148
Test_org_eclipse_swt_widgets_Composite.class, //
49+
Test_org_eclipse_swt_widgets_CoolBar.class, //
50+
// Failing test: Test_org_eclipse_swt_widgets_CoolItem.class, //
4251
Test_org_eclipse_swt_widgets_DateTime.class, //
4352
Test_org_eclipse_swt_widgets_DirectoryDialog.class, //
4453
Test_org_eclipse_swt_widgets_Event.class, //
@@ -71,6 +80,7 @@
7180
Test_org_eclipse_swt_widgets_ToolBar.class, //
7281
Test_org_eclipse_swt_widgets_ToolItem.class, //
7382
Test_org_eclipse_swt_widgets_Tree.class, //
83+
Test_org_eclipse_swt_widgets_TreeColumn.class, //
7484
Test_org_eclipse_swt_widgets_TreeItem.class, //
7585
})
7686
public class AllWidgetTests {

tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_widgets_Decorations.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
*
4040
* @see org.eclipse.swt.widgets.Decorations
4141
*/
42-
public class Test_org_eclipse_swt_widgets_Decorations extends Test_org_eclipse_swt_widgets_Canvas {
42+
public abstract class Test_org_eclipse_swt_widgets_Decorations extends Test_org_eclipse_swt_widgets_Canvas {
4343

4444
@Override
4545
@Test

tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_widgets_Dialog.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
*
2929
* @see org.eclipse.swt.widgets.Dialog
3030
*/
31-
public class Test_org_eclipse_swt_widgets_Dialog {
31+
public abstract class Test_org_eclipse_swt_widgets_Dialog {
3232

3333
@BeforeEach
3434
public void setUp() {

tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_widgets_Item.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
*
3434
* @see org.eclipse.swt.widgets.Item
3535
*/
36-
public class Test_org_eclipse_swt_widgets_Item extends Test_org_eclipse_swt_widgets_Widget {
36+
public abstract class Test_org_eclipse_swt_widgets_Item extends Test_org_eclipse_swt_widgets_Widget {
3737

3838
@Override
3939
@Before

tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_widgets_Scrollable.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
*
2323
* @see org.eclipse.swt.widgets.Scrollable
2424
*/
25-
public class Test_org_eclipse_swt_widgets_Scrollable extends Test_org_eclipse_swt_widgets_Control {
25+
public abstract class Test_org_eclipse_swt_widgets_Scrollable extends Test_org_eclipse_swt_widgets_Control {
2626

2727
@Override
2828
@Test

0 commit comments

Comments
 (0)