Sporadically failing Browser Tests logging #1466

amartya4256 · amartya4256 · commit 169cbcaf329c · 2025-06-02T15:34:12.000+02:00
This commit adds relevant loggings for debugging purposes to the Browser tests which sporadically fail for Edge Browser. contributes to #2098, #2113 and #2063
diff --git a/tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_browser_Browser.java b/tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_browser_Browser.java
@@ -587,11 +587,16 @@ public void test_LocationListener_changing() {
 @Test
 public void test_LocationListener_changed() {
 	AtomicBoolean changedFired = new AtomicBoolean(false);
-	browser.addLocationListener(changedAdapter(e ->	changedFired.set(true)));
+	browser.addLocationListener(changedAdapter(e ->	{
+			changedFired.set(true);
+		}));
 	shell.open();
 	browser.setText("Hello world");
 	boolean passed = waitForPassCondition(changedFired::get);
-	assertTrue("LocationListener.changed() event was never fired", passed);
+	String errorMsg = String.format(
+			"LocationListener.changed() event was never fired. Browser URL after waitForPassCondition: %s",
+			browser.getUrl());
+	assertTrue(errorMsg, passed);
 }
 @Test
 public void test_LocationListener_changed_twoSetTextCycles() {
@@ -654,10 +659,12 @@ public void test_LocationListener_then_ProgressListener() {
 	AtomicBoolean locationChanged = new AtomicBoolean(false);
 	AtomicBoolean progressChanged = new AtomicBoolean(false);
 	AtomicBoolean progressChangedAfterLocationChanged = new AtomicBoolean(false);
+	AtomicReference<String> browserTextOnCompletedEvent = new AtomicReference<>();
 
 	browser.addLocationListener(changedAdapter(event ->	locationChanged.set(true)));
 
 	browser.addProgressListener(completedAdapter(event -> {
+		browserTextOnCompletedEvent.set(browser.getText());
 		if (locationChanged.get()) {
 			progressChangedAfterLocationChanged.set(true);
 		}
@@ -671,8 +678,9 @@ public void test_LocationListener_then_ProgressListener() {
 	String errorMsg = "\nUnexpected listener states. Expecting true for all, but have:\n"
 			+ "Location changed: " + locationChanged.get() + "\n"
 			+ "ProgressChangedAfterLocationChanged: " + progressChangedAfterLocationChanged.get() + "\n"
-			+ "progressChanged: " + progressChanged.get();
-
+			+ "progressChanged: " + progressChanged.get()
+			+ "browser text on completed event: " + browserTextOnCompletedEvent.get()
+			+ "browser text after waitForPassCondition: " + browser.getText();
 	assertTrue(errorMsg, progressChangedAfterLocationChanged.get());
 }
 
@@ -986,6 +994,7 @@ public void completed(ProgressEvent event) {
 @Test
 public void test_ProgressListener_completed_Called() {
 	AtomicBoolean childCompleted = new AtomicBoolean(false);
+	AtomicReference<String> browserTextOnChangedEvent = new AtomicReference<>();
 	ProgressListener l = new ProgressListener() {
 
 		@Override
@@ -995,14 +1004,16 @@ public void completed(ProgressEvent event) {
 
 		@Override
 		public void changed(ProgressEvent event) {
-
+			browserTextOnChangedEvent.set(browser.getText());
 		}
 	};
 	browser.addProgressListener(l);
 	browser.setText("<html><body>This test ensures that the completed listener is called.</body></html>");
 	shell.open();
 	boolean passed = waitForPassCondition(childCompleted::get);
-	assertTrue(passed);
+	String errorMsg = "Browser text before completed: " + browserTextOnChangedEvent.get() +
+					"\nBrowser text after completed: " + browser.getText();
+	assertTrue(errorMsg, passed);
 }
 
 @Test
