Skip to content

Commit 1a53931

Browse files
committed
refactor test class
1 parent dd217b0 commit 1a53931

File tree

1 file changed

+16
-28
lines changed

1 file changed

+16
-28
lines changed

tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_internal_SVGRasterizer.java

Lines changed: 16 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -25,28 +25,10 @@
2525
import org.eclipse.swt.graphics.ImageDataProvider;
2626
import org.eclipse.swt.graphics.ImageFileNameProvider;
2727
import org.eclipse.swt.widgets.Display;
28-
import org.junit.Before;
2928
import org.junit.Test;
3029

3130
public class Test_org_eclipse_swt_internal_SVGRasterizer {
3231

33-
Display display;
34-
35-
ImageFileNameProvider imageFileNameProvider = zoom -> {
36-
String fileName = "collapseall.svg";
37-
return getPath(fileName);
38-
};
39-
40-
ImageDataProvider imageDataProvider = zoom -> {
41-
String fileName = "collapseall.svg";
42-
return new ImageData(getPath(fileName));
43-
};
44-
45-
@Before
46-
public void setUp() {
47-
display = Display.getDefault();
48-
}
49-
5032
String getPath(String fileName) {
5133
String urlPath = "";
5234
String pluginPath = System.getProperty("PLUGIN_PATH");
@@ -69,16 +51,19 @@ String getPath(String fileName) {
6951

7052
@Test
7153
public void test_ConstructorLorg_eclipse_swt_graphics_Device_ImageFileNameProvider() {
72-
// Valid provider
73-
Image image = new Image(display, imageFileNameProvider);
54+
ImageFileNameProvider validImageFileNameProvider = zoom -> {
55+
String fileName = "collapseall.svg";
56+
return getPath(fileName);
57+
};
58+
Image image = new Image(Display.getDefault(), validImageFileNameProvider);
7459
image.dispose();
75-
// Corrupt Image provider
76-
ImageFileNameProvider provider = zoom -> {
60+
61+
ImageFileNameProvider corruptImageFileNameProvider = zoom -> {
7762
String fileName = "corrupt.svg";
7863
return getPath(fileName);
7964
};
8065
try {
81-
image = new Image(display, provider);
66+
image = new Image(Display.getDefault(), corruptImageFileNameProvider);
8267
image.dispose();
8368
fail("No exception thrown for corrupt image file.");
8469
} catch (SWTException e) {
@@ -88,16 +73,19 @@ public void test_ConstructorLorg_eclipse_swt_graphics_Device_ImageFileNameProvid
8873

8974
@Test
9075
public void test_ConstructorLorg_eclipse_swt_graphics_Device_ImageDataProvider() {
91-
// Valid provider
92-
Image image = new Image(display, imageDataProvider);
76+
ImageDataProvider validImageDataProvider = zoom -> {
77+
String fileName = "collapseall.svg";
78+
return new ImageData(getPath(fileName));
79+
};
80+
Image image = new Image(Display.getDefault(), validImageDataProvider);
9381
image.dispose();
94-
// Corrupt Image provider
95-
ImageDataProvider provider = zoom -> {
82+
83+
ImageDataProvider corruptImageDataProvider = zoom -> {
9684
String fileName = "corrupt.svg";
9785
return new ImageData(getPath(fileName));
9886
};
9987
try {
100-
image = new Image(display, provider);
88+
image = new Image(Display.getDefault(), corruptImageDataProvider);
10189
image.dispose();
10290
fail("No exception thrown for corrupt image file.");
10391
} catch (SWTException e) {

0 commit comments

Comments
 (0)