Skip to content

Commit 1b2ea28

Browse files
committed
[Win32] Add missing releases of queried WebView interfaces
For some recently added WebView interface retrievals, the according release operations on disposal are missing. This change adds them.
1 parent 081eb9b commit 1b2ea28

File tree

1 file changed

+3
-1
lines changed
  • bundles/org.eclipse.swt/Eclipse SWT Browser/win32/org/eclipse/swt/browser

1 file changed

+3
-1
lines changed

bundles/org.eclipse.swt/Eclipse SWT Browser/win32/org/eclipse/swt/browser/Edge.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ ICoreWebView2 initializeWebView(ICoreWebView2Controller controller) {
311311
webViewWrapper.webView_10 = initializeWebView_10(webView);
312312
webViewWrapper.webView_11 = initializeWebView_11(webView);
313313
webViewWrapper.webView_12 = initializeWebView_12(webView);
314-
webViewWrapper.webView_13= initializeWebView_13(webView);
314+
webViewWrapper.webView_13 = initializeWebView_13(webView);
315315
webViewWrapperFuture.complete(webViewWrapper);
316316
return webView;
317317
}
@@ -744,8 +744,10 @@ void browserDispose(Event event) {
744744
if (environment2 != null) environment2.Release();
745745
if (settings != null) settings.Release();
746746
if (webViewProvider.isWebView_2Available()) webViewProvider.getWebView_2(false).Release();
747+
if (webViewProvider.isWebView_10Available()) webViewProvider.getWebView_10(false).Release();
747748
if (webViewProvider.isWebView_11Available()) webViewProvider.getWebView_11(false).Release();
748749
if (webViewProvider.isWebView_12Available()) webViewProvider.getWebView_12(false).Release();
750+
if (webViewProvider.isWebView_13Available()) webViewProvider.getWebView_13(false).Release();
749751
if(controller != null) {
750752
// Bug in WebView2. Closing the controller from an event handler results
751753
// in a crash. The fix is to delay the closure with asyncExec.

0 commit comments

Comments
 (0)