Add exception to setImageMetadataForHandle

amartya4256 · fedejeanne · commit 2400fff7da43 · 2024-12-18T09:27:20.000+01:00
This commit adds a check for imageMetadata for handle in case, there already exists an entry in the zoomLeveltoImageHandle map for a zoom level and it must throw an exception in that case. contributes to #62 and #127
diff --git a/bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java b/bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
@@ -1788,9 +1788,12 @@ else if (i.alphaData != null) {
 }
 
 private void setImageMetadataForHandle(ImageHandle imageMetadata, Integer zoom) {
-	if (zoom != null && !zoomLevelToImageHandle.containsKey(zoom)) {
-		zoomLevelToImageHandle.put(zoom, imageMetadata);
+	if (zoom == null)
+		return;
+	if (zoomLevelToImageHandle.containsKey(zoom)) {
+		SWT.error(SWT.ERROR_ITEM_NOT_ADDED);
 	}
+	zoomLevelToImageHandle.put(zoom, imageMetadata);
 }
 
 static long [] init(Device device, Image image, ImageData source, ImageData mask, Integer zoom) {

Original file line number	Diff line number	Diff line change
`@@ -1788,9 +1788,12 @@ else if (i.alphaData != null) {`
`1788`	`1788`	`}`
`1789`	`1789`
`1790`	`1790`	`private void setImageMetadataForHandle(ImageHandle imageMetadata, Integer zoom) {`
`1791`		`- if (zoom != null && !zoomLevelToImageHandle.containsKey(zoom)) {`
`1792`		`- zoomLevelToImageHandle.put(zoom, imageMetadata);`
	`1791`	`+ if (zoom == null)`
	`1792`	`+ return;`
	`1793`	`+ if (zoomLevelToImageHandle.containsKey(zoom)) {`
	`1794`	`+ SWT.error(SWT.ERROR_ITEM_NOT_ADDED);`
`1793`	`1795`	`}`
	`1796`	`+ zoomLevelToImageHandle.put(zoom, imageMetadata);`
`1794`	`1797`	`}`
`1795`	`1798`
`1796`	`1799`	`static long [] init(Device device, Image image, ImageData source, ImageData mask, Integer zoom) {`