[win32] Utilize temporary image handles

This commit adapts all places, where operation where executed with
OS handles created for a specific zoom that could use any zoom. Therefor
now any existing handle is used or, if none exists yet, a temporary handle
is created and destroyed afterwards.

Author: akoch-yatta

bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java

@@ -253,32 +253,32 @@ public Image(Device device, Image srcImage, int flag) {
 		case SWT.IMAGE_COPY: {
 			switch (type) {
 				case SWT.BITMAP:
-					/* Get the HDC for the device */
-					long hDC = device.internal_new_GC(null);
-
-					/* Copy the bitmap */
-					long hdcSource = OS.CreateCompatibleDC(hDC);
-					long hdcDest = OS.CreateCompatibleDC(hDC);
-					long hOldSrc = OS.SelectObject(hdcSource, srcImageHandle);
-					BITMAP bm = new BITMAP();
-					OS.GetObject(srcImageHandle, BITMAP.sizeof, bm);
+						/* Get the HDC for the device */
+						long hDC = device.internal_new_GC(null);
+
+						/* Copy the bitmap */
+						long hdcSource = OS.CreateCompatibleDC(hDC);
+						long hdcDest = OS.CreateCompatibleDC(hDC);
+						long hOldSrc = OS.SelectObject(hdcSource, srcImageHandle);
+						BITMAP bm = new BITMAP();
+						OS.GetObject(srcImageHandle, BITMAP.sizeof, bm);
 					imageMetadata = new ImageHandle(OS.CreateCompatibleBitmap(hdcSource, rect.width, bm.bmBits != 0 ? -rect.height : rect.height), getZoom());
-					if (imageMetadata.handle == 0) SWT.error(SWT.ERROR_NO_HANDLES);
-					long hOldDest = OS.SelectObject(hdcDest, imageMetadata.handle);
-					OS.BitBlt(hdcDest, 0, 0, rect.width, rect.height, hdcSource, 0, 0, OS.SRCCOPY);
-					OS.SelectObject(hdcSource, hOldSrc);
-					OS.SelectObject(hdcDest, hOldDest);
-					OS.DeleteDC(hdcSource);
-					OS.DeleteDC(hdcDest);
-
-					/* Release the HDC for the device */
-					device.internal_dispose_GC(hDC, null);
+						if (imageMetadata.handle == 0) SWT.error(SWT.ERROR_NO_HANDLES);
+						long hOldDest = OS.SelectObject(hdcDest, imageMetadata.handle);
+						OS.BitBlt(hdcDest, 0, 0, rect.width, rect.height, hdcSource, 0, 0, OS.SRCCOPY);
+						OS.SelectObject(hdcSource, hOldSrc);
+						OS.SelectObject(hdcDest, hOldDest);
+						OS.DeleteDC(hdcSource);
+						OS.DeleteDC(hdcDest);
+
+						/* Release the HDC for the device */
+						device.internal_dispose_GC(hDC, null);
 
 					transparentPixel = srcImage.transparentPixel;
 					break;
 				case SWT.ICON:
 					imageMetadata = new ImageHandle(OS.CopyImage(srcImageHandle, OS.IMAGE_ICON, rect.width, rect.height, 0), getZoom());
-					if (imageMetadata.handle == 0) SWT.error(SWT.ERROR_NO_HANDLES);
+						if (imageMetadata.handle == 0) SWT.error(SWT.ERROR_NO_HANDLES);
 					break;
 				default:
 					SWT.error(SWT.ERROR_INVALID_IMAGE);
@@ -287,13 +287,13 @@ public Image(Device device, Image srcImage, int flag) {
 		}
 		case SWT.IMAGE_DISABLE: {
 			ImageData data = srcImage.getImageData(srcImage.getZoom());
-			ImageData newData = applyDisableImageData(data, rect.height, rect.width);
+				ImageData newData = applyDisableImageData(data, rect.height, rect.width);
 			init (newData, getZoom());
 			break;
 		}
 		case SWT.IMAGE_GRAY: {
 			ImageData data = srcImage.getImageData(srcImage.getZoom());
-			ImageData newData = applyGrayImageData(data, rect.height, rect.width);
+				ImageData newData = applyGrayImageData(data, rect.height, rect.width);
 			init (newData, getZoom());
 			break;
 		}
@@ -1089,47 +1089,48 @@ public Color getBackground() {
 
 	/* Get the HDC for the device */
 	long hDC = device.internal_new_GC(null);
-	long handle = win32_getHandle(this, getZoom());
-
-	/* Compute the background color */
-	BITMAP bm = new BITMAP();
-	OS.GetObject(handle, BITMAP.sizeof, bm);
-	long hdcMem = OS.CreateCompatibleDC(hDC);
-	long hOldObject = OS.SelectObject(hdcMem, handle);
-	int red = 0, green = 0, blue = 0;
-	if (bm.bmBitsPixel <= 8)  {
-		byte[] color = new byte[4];
-		OS.GetDIBColorTable(hdcMem, transparentPixel, 1, color);
-		blue = color[0] & 0xFF;
-		green = color[1] & 0xFF;
-		red = color[2] & 0xFF;
-	} else {
-		switch (bm.bmBitsPixel) {
-			case 16:
-				blue = (transparentPixel & 0x1F) << 3;
-				green = (transparentPixel & 0x3E0) >> 2;
-				red = (transparentPixel & 0x7C00) >> 7;
-				break;
-			case 24:
-				blue = (transparentPixel & 0xFF0000) >> 16;
-				green = (transparentPixel & 0xFF00) >> 8;
-				red = transparentPixel & 0xFF;
-				break;
-			case 32:
-				blue = (transparentPixel & 0xFF000000) >>> 24;
-				green = (transparentPixel & 0xFF0000) >> 16;
-				red = (transparentPixel & 0xFF00) >> 8;
-				break;
-			default:
-				return null;
+	return applyUsingAnyHandle(imageHandle -> {
+		long handle = imageHandle.handle;
+		/* Compute the background color */
+		BITMAP bm = new BITMAP();
+		OS.GetObject(handle, BITMAP.sizeof, bm);
+		long hdcMem = OS.CreateCompatibleDC(hDC);
+		long hOldObject = OS.SelectObject(hdcMem, handle);
+		int red = 0, green = 0, blue = 0;
+		if (bm.bmBitsPixel <= 8)  {
+			byte[] color = new byte[4];
+			OS.GetDIBColorTable(hdcMem, transparentPixel, 1, color);
+			blue = color[0] & 0xFF;
+			green = color[1] & 0xFF;
+			red = color[2] & 0xFF;
+		} else {
+			switch (bm.bmBitsPixel) {
+				case 16:
+					blue = (transparentPixel & 0x1F) << 3;
+					green = (transparentPixel & 0x3E0) >> 2;
+					red = (transparentPixel & 0x7C00) >> 7;
+					break;
+				case 24:
+					blue = (transparentPixel & 0xFF0000) >> 16;
+					green = (transparentPixel & 0xFF00) >> 8;
+					red = transparentPixel & 0xFF;
+					break;
+				case 32:
+					blue = (transparentPixel & 0xFF000000) >>> 24;
+					green = (transparentPixel & 0xFF0000) >> 16;
+					red = (transparentPixel & 0xFF00) >> 8;
+					break;
+				default:
+					return null;
+			}
 		}
-	}
-	OS.SelectObject(hdcMem, hOldObject);
-	OS.DeleteDC(hdcMem);
+		OS.SelectObject(hdcMem, hOldObject);
+		OS.DeleteDC(hdcMem);
 
-	/* Release the HDC for the device */
-	device.internal_dispose_GC(hDC, null);
-	return Color.win32_new(device, (blue << 16) | (green << 8) | red);
+		/* Release the HDC for the device */
+		device.internal_dispose_GC(hDC, null);
+		return Color.win32_new(device, (blue << 16) | (green << 8) | red);
+	});
 }
 
 /**
@@ -1176,7 +1177,9 @@ Rectangle getBounds(int zoom) {
  */
 @Deprecated
 public Rectangle getBoundsInPixels() {
-	return getBounds(getZoom());
+	return applyUsingAnyHandle(imageHandle -> {
+		return imageHandle.getBounds();
+	});
 }
 
 /**
@@ -1258,7 +1261,9 @@ public ImageData getImageData (int zoom) {
  */
 @Deprecated
 public ImageData getImageDataAtCurrentZoom() {
-	return getImageMetadata(getZoom()).getImageData();
+	return applyUsingAnyHandle(imageHandle -> {
+		return imageHandle.getImageData();
+	});
 }
 
 /**
@@ -1832,6 +1837,19 @@ public String toString () {
 	return "Image {" + zoomLevelToImageHandle + "}";
 }
 
+<T> T applyUsingAnyHandle(Function<ImageHandle, T> function) {
+	if (zoomLevelToImageHandle.isEmpty()) {
+		ImageHandle temporaryHandle = this.imageProvider.newImageHandle(DPIUtil.getDeviceZoom());
+		try {
+			return function.apply(temporaryHandle);
+		} finally {
+			temporaryHandle.destroy();
+		}
+	} else {
+		return function.apply(zoomLevelToImageHandle.values().iterator().next());
+	}
+}
+
 /**
  * Invokes platform specific functionality to allocate a new image.
  * <p>
@@ -2558,6 +2576,10 @@ public ImageHandle(long handle, int zoom) {
 		setImageMetadataForHandle(this, zoom);
 	}
 
+	public Rectangle getBounds() {
+		return new Rectangle(0, 0, width, height);
+	}
+
 	private void setBackground(RGB color) {
 		if (transparentPixel == -1) return;