Store beep property evaluation in static boolean field and remove test cases

Co-authored-by: laeubi <[email protected]>

Author: Copilot

bundles/org.eclipse.swt/Eclipse SWT/cocoa/org/eclipse/swt/widgets/Display.java

@@ -117,7 +117,7 @@ enum APPEARANCE {
 	/* System property to be set for SWT application to use the system's theme */
 	static final String USE_SYSTEM_THEME = "org.eclipse.swt.display.useSystemTheme";
 	/* System property to control beep sounds */
-	static final String BEEP_ENABLED = "swt.beep";
+	public static final boolean BEEP_ENABLED = !"off".equalsIgnoreCase(System.getProperty("swt.beep"));
 
 	/* Windows and Events */
 	Event [] eventQueue;
@@ -673,7 +673,7 @@ public void execute(Runnable runnable) {
  */
 public void beep () {
 	checkDevice ();
-	if (!"off".equalsIgnoreCase(System.getProperty(BEEP_ENABLED))) {
+	if (BEEP_ENABLED) {
 		OS.NSBeep ();
 	}
 }

bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Display.java

@@ -510,7 +510,7 @@ public void stop() {
 	/* Package name */
 	static final String PACKAGE_PREFIX = "org.eclipse.swt.widgets."; //$NON-NLS-1$
 	/* System property to control beep sounds */
-	static final String BEEP_ENABLED = "swt.beep";
+	public static final boolean BEEP_ENABLED = !"off".equalsIgnoreCase(System.getProperty("swt.beep"));
 	/* This code is intentionally commented.
 	 * ".class" can not be used on CLDC.
 	 */
@@ -990,7 +990,7 @@ public void execute(Runnable runnable) {
  */
 public void beep () {
 	if (!isValidThread ()) error (SWT.ERROR_THREAD_INVALID_ACCESS);
-	if (!"off".equalsIgnoreCase(System.getProperty(BEEP_ENABLED))) {
+	if (BEEP_ENABLED) {
 		GDK.gdk_display_beep(GDK.gdk_display_get_default());
 	}
 }

bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Display.java

@@ -225,7 +225,7 @@ public class Display extends Device implements Executor {
 	static final String USE_WS_BORDER_TEXT_KEY       = "org.eclipse.swt.internal.win32.Text.use_WS_BORDER"; //$NON-NLS-1$
 	boolean useWsBorderText = false;
 	/* System property to control beep sounds */
-	static final String BEEP_ENABLED = "swt.beep";
+	public static final boolean BEEP_ENABLED = !"off".equalsIgnoreCase(System.getProperty("swt.beep"));
 	/**
 	 * Changes the color of Table header's column delimiters.
 	 * Only affects custom-drawn header, that is when background/foreground header color is set.
@@ -854,7 +854,7 @@ public void execute(Runnable runnable) {
  */
 public void beep () {
 	checkDevice ();
-	if (!"off".equalsIgnoreCase(System.getProperty(BEEP_ENABLED))) {
+	if (BEEP_ENABLED) {
 		OS.MessageBeep (OS.MB_OK);
 	}
 }

tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_widgets_Display.java

@@ -231,50 +231,6 @@ public void test_beep() {
 	}
 }
 
-@Test
-public void test_beep_disabled() {
-	String originalValue = System.getProperty("swt.beep");
-	try {
-		System.setProperty("swt.beep", "off");
-		Display display = new Display();
-		try {
-			// Should not beep when property is "off"
-			display.beep();
-		} finally {
-			display.dispose();
-		}
-	} finally {
-		// Restore original value
-		if (originalValue != null) {
-			System.setProperty("swt.beep", originalValue);
-		} else {
-			System.clearProperty("swt.beep");
-		}
-	}
-}
-
-@Test
-public void test_beep_enabled() {
-	String originalValue = System.getProperty("swt.beep");
-	try {
-		System.setProperty("swt.beep", "on");
-		Display display = new Display();
-		try {
-			// Should beep when property is "on"
-			display.beep();
-		} finally {
-			display.dispose();
-		}
-	} finally {
-		// Restore original value
-		if (originalValue != null) {
-			System.setProperty("swt.beep", originalValue);
-		} else {
-			System.clearProperty("swt.beep");
-		}
-	}
-}
-
 @Test
 public void test_close() {
 	Display display = new Display();