Make FontData key in map immutable

Creating clone of FontData to be used as a key in map of
ScalingSWTFontRegistry and DefaultSWTFontRegistry to make it immutable
and inaccessible from outside of the class

Author: ShahzaibIbrahim

bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/internal/DefaultSWTFontRegistry.java

@@ -72,7 +72,8 @@ public Font getFont(FontData fontData, int zoom) {
 	}
 
 	private Font registerFont(FontData fontData, Font font) {
-		fontsMap.put(fontData, font);
+		FontData clonedFontData = new FontData(fontData.toString());
+		fontsMap.put(clonedFontData, font);
 		return font;
 	}
 

bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/internal/ScalingSWTFontRegistry.java

@@ -130,8 +130,9 @@ public Font getFont(FontData fontData, int zoom) {
 		if (customFontsKeyMap.containsKey(fontData)) {
 			container = customFontsKeyMap.get(fontData);
 		} else {
-			container = new ScaledCustomFontContainer(fontData);
-			customFontsKeyMap.put(fontData, container);
+			FontData clonedFontData = new FontData(fontData.toString());
+			container = new ScaledCustomFontContainer(clonedFontData);
+			customFontsKeyMap.put(clonedFontData, container);
 		}
 		return container.getScaledFont(zoom);
 	}

tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_graphics_FontData.java

@@ -45,6 +45,7 @@ public void test_ConstructorLjava_lang_String() {
 	FontData fd = new FontData(SwtTestUtil.testFontName, 10, SWT.NORMAL);
 	FontData reconstructedFontData = new FontData(fd.toString());
 	assertEquals(fd, reconstructedFontData);
+	assertEquals(fd.hashCode(), reconstructedFontData.hashCode());
 }
 
 @Test