more cleanup

tobias-melcher · tobias-melcher · commit 4d9d7e6a1f99 · 2025-07-28T19:27:57.000+02:00
diff --git a/bundles/org.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/StyledText.java b/bundles/org.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/StyledText.java
@@ -3903,10 +3903,9 @@ public int getLinePixel(int lineIndex) {
 			height += renderer.getLineHeight(i);
 		}
 	} else {
-		for (int i = topIndex - 1; i >= lineIndex; i--) {
-			if (i < 0 || i >= lineCount) {
-				continue;
-			}
+		int lastLineToConsider = Math.min(topIndex - 1, lineCount - 1);
+		int firstLineToConsider = Math.max(0, lineIndex);
+		for (int i = firstLineToConsider; i <= lastLineToConsider; i++) {
 			height -= renderer.getLineHeight(i);
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -3903,10 +3903,9 @@ public int getLinePixel(int lineIndex) {`
`3903`	`3903`	`height += renderer.getLineHeight(i);`
`3904`	`3904`	`}`
`3905`	`3905`	`} else {`
`3906`		`- for (int i = topIndex - 1; i >= lineIndex; i--) {`
`3907`		`- if (i < 0 \|\| i >= lineCount) {`
`3908`		`- continue;`
`3909`		`- }`
	`3906`	`+ int lastLineToConsider = Math.min(topIndex - 1, lineCount - 1);`
	`3907`	`+ int firstLineToConsider = Math.max(0, lineIndex);`
	`3908`	`+ for (int i = firstLineToConsider; i <= lastLineToConsider; i++) {`
`3910`	`3909`	`height -= renderer.getLineHeight(i);`
`3911`	`3910`	`}`
`3912`	`3911`	`}`